Improve doc wording for retain on some collections #94826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @yaahc (or someone else) soon. Please see the contribution instructions for more information. |
|
looks great, thank you! @bors r+ rollup |
|
📌 Commit 229e01d has been approved by |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 11, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#93293 (Implement `MIN`/`MAX` constants for non-zero integers) - rust-lang#94356 (Rename unix::net::SocketAddr::from_path to from_pathname and stabilize it) - rust-lang#94765 (Rename is_{some,ok,err}_with to is_{some,ok,err}_and.) - rust-lang#94819 (configure: don't serialize empty array elements) - rust-lang#94826 (Improve doc wording for retain on some collections) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the documentation wording on the various retain methods on many collections to be unusual.
I tried to invert the relation by switching
such thatwithfor which.