Skip to content

Improve method name suggestions #95119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2022
Merged

Improve method name suggestions #95119

merged 1 commit into from
Apr 4, 2022

Conversation

OliverMD
Copy link
Contributor

Attempts to improve method name suggestions when a matching method name
is not found. The approach taken is use the Levenshtein distance and
account for substrings having a high distance but can sometimes be very
close to the intended method (eg. empty vs is_empty).

resolves #94747

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 19, 2022
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 19, 2022
davidtwco
davidtwco requested changes Apr 3, 2022
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good improvement, apologies that it took a while for this to be reviewed, I've left a few comments.

@davidtwco
Copy link
Member

r? @davidtwco

@rust-highfive rust-highfive assigned davidtwco and unassigned estebank Apr 3, 2022
@davidtwco davidtwco added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 3, 2022
@OliverMD OliverMD force-pushed the method_suggestions branch from a08819d to 6a30a77 Compare April 3, 2022 15:22
@OliverMD
Improve method name suggestions
e2dfa23 
Attempts to improve method name suggestions when a matching method name
is not found. The approach taken is use the Levenshtein distance and
account for substrings having a high distance but can sometimes be very
close to the intended method (eg. empty vs is_empty).
@OliverMD OliverMD force-pushed the method_suggestions branch from 6a30a77 to e2dfa23 Compare April 3, 2022 15:39
@OliverMD
Copy link
Contributor Author

OliverMD commented Apr 3, 2022

Thanks for the review @davidtwco! I've pushed some changes based on the review.

davidtwco
davidtwco approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a good improvement!

@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 4, 2022

📌 Commit e2dfa23 has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 4, 2022
@scottmcm scottmcm added the relnotes Marks issues that should be documented in the release notes of the next release. label Apr 4, 2022
@bors
Copy link
Collaborator

bors commented Apr 4, 2022

⌛ Testing commit e2dfa23 with merge d5139f4...

@bors
Copy link
Collaborator

bors commented Apr 4, 2022

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing d5139f4 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 4, 2022
@bors bors merged commit d5139f4 into rust-lang:master Apr 4, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 4, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d5139f4): comparison url.

Summary:

  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: no relevant changes found. 1 results were found to be statistically significant but too small to be relevant.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
merged-by-bors This PR was explicitly merged by bors. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.

improve similar method names suggestions
8 participants
@OliverMD @rust-highfive @davidtwco @bors @rust-timer @estebank @scottmcm @rustbot