Skip to content

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented May 6, 2022

I had this overridden locally for a while and realized just now it should probably just be a default.

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 6, 2022
@jyn514 jyn514 force-pushed the compiler-docs-default branch from f8da27a to 7443cc2 Compare May 6, 2022 01:05
@Mark-Simulacrum
Copy link
Member

Seems OK -- if you're building docs locally this is probably true. Not sure how many folks outside of rustdoc developers are doing that though.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 7, 2022

📌 Commit 7443cc2 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 7, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request May 7, 2022
…askrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#96336 (Link to correct `as_mut` in docs for `pointer::as_ref`)
 - rust-lang#96586 (Add aliases for std::fs::canonicalize)
 - rust-lang#96667 (Add regression test)
 - rust-lang#96671 (Remove hard links from `env::current_exe` security example)
 - rust-lang#96726 (Add regression and bug tests)
 - rust-lang#96756 (Enable compiler-docs by default for `compiler`, `codegen`, and `tools` profiles)
 - rust-lang#96757 (Don't constantly rebuild clippy on `x test src/tools/clippy`.)
 - rust-lang#96769 (Remove `adx_target_feature` feature from active features list)
 - rust-lang#96777 (Make the test `check-pass` not to produce a JSON file)
 - rust-lang#96822 (Enforce quote rule for JS source code)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 16892cf into rust-lang:master May 8, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 8, 2022
@jyn514 jyn514 deleted the compiler-docs-default branch February 25, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants