Skip to content

Conversation

voidc
Copy link
Contributor

@voidc voidc commented Jun 28, 2022

This implements the changes outlined in #66451 (comment).

r? @lcnr
Fixes #66451

@rustbot
Copy link
Collaborator

rustbot commented Jun 28, 2022

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 28, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 28, 2022
Copy link
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some possible further improvements to destructure_const, then r=me

thanks ❤️

@lcnr
Copy link
Contributor

lcnr commented Jun 29, 2022

@bors delegate+

@bors
Copy link
Collaborator

bors commented Jun 29, 2022

✌️ @voidc can now approve this pull request

@lcnr
Copy link
Contributor

lcnr commented Jun 29, 2022

with @bors delegate+ you can do @bors r=<name-of-reviewer> yourself, without having to wait for the reviewer to look at your last changes.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 29, 2022

📌 Commit d048b15 has been approved by ```

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 29, 2022
@lcnr
Copy link
Contributor

lcnr commented Jun 29, 2022

gdi bors xd

@lcnr
Copy link
Contributor

lcnr commented Jun 29, 2022

@bors r-
@bors r+

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 29, 2022
@bors
Copy link
Collaborator

bors commented Jun 29, 2022

📌 Commit d048b15 has been approved by lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 29, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 29, 2022
…askrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#98434 (Ensure that `static_crt` is set in the bootstrapper whenever using `cc-rs` to get a compiler command line.)
 - rust-lang#98636 (Triagebot: Fix mentions word wrapping.)
 - rust-lang#98642 (Fix rust-lang#98260)
 - rust-lang#98643 (Improve pretty printing of valtrees for references)
 - rust-lang#98646 (rustdoc: fix bugs in main.js popover help and settings)
 - rust-lang#98647 (Update cargo)
 - rust-lang#98652 (`alloc`: clean and ensure `no_global_oom_handling`  builds are warning-free)
 - rust-lang#98660 (Unbreak stage1 tests via ignore-stage1 in `proc-macro/invalid-punct-ident-1.rs`.)
 - rust-lang#98665 (Use verbose help for deprecation suggestion)
 - rust-lang#98668 (Avoid some `&str` to `String` conversions with `MultiSpan::push_span_label`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 921e311 into rust-lang:master Jun 29, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Debug representation in const value pretty print
5 participants