Revert "Revert "Use ICF (identical code folding) for building rustc"" #99680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit rust-lang/rust@45575d2, thereby enabling identical code folding again.
|
(rust-highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ rollup=never |
lqd
reviewed
Jul 25, 2022
| @@ -195,3 +195,7 @@ rm -r $BUILD_ARTIFACTS/llvm $BUILD_ARTIFACTS/lld | |||
| $@ \ | |||
| --rust-profile-use=${RUSTC_PROFILE_MERGED_FILE} \ | |||
| --llvm-profile-use=${LLVM_PROFILE_MERGED_FILE} | |||
|
|
|||
| echo "Rustc binary size" | |||
| ls -la ./build/$PGO_HOST/stage2/bin | |||
There was a problem hiding this comment.
./build/$PGO_HOST/ can be $BUILD_ARTIFACTS
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (c9b3183): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Aug 13, 2022
Make `[rust] use-lld=true` work on windows Before, it would fail with "error: ignoring unknown argument '-Wl,--icf=all'" This option was introduced in rust-lang#99062 (well, technically rust-lang#99680) See zulip thread: https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/rust-lld.3A.20error.3A.20ignoring.20unknown.20argument.20'-Wl.2C--icf.3Dall'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 45575d2,
thereby enabling identical code folding again.
Closes #99440 (again).