Skip to content

Changed test logger behavior to avoid expected error logging #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Changed test logger behavior to avoid expected error logging #757

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/test/java/io/socket/parser/ParserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
package io.socket.parser;

import java.util.logging.Level;
import java.util.logging.Logger;

import org.json.JSONArray;
import org.json.JSONException;
import org.junit.Test;
Expand Down Expand Up @@ -49,6 +52,9 @@ public void encodeAck() throws JSONException {

@Test
public void decodeInError() throws JSONException {
Logger logger = Logger.getLogger(IOParser.class.getName());
Level tmpLevel = logger.getLevel();
logger.setLevel(Level.SEVERE);
// Random string
Helpers.testDecodeError("asdf");
// Unknown type
Expand All @@ -62,9 +68,10 @@ public void decodeInError() throws JSONException {
// event non numeric id
Helpers.testDecodeError(Parser.EVENT + "2sd");
// event with invalid json data
Helpers.testDecodeError(Parser.EVENT + "2[\"a\",1,{asdf}]");
Helpers.testDecodeError(Parser.EVENT + "2{}");
Helpers.testDecodeError(Parser.EVENT + "2[]");
Helpers.testDecodeError(Parser.EVENT + "2[null]");
Helpers.testDecodeError(Parser.EVENT + "2[\"a\",1,{asdf}]");
logger.setLevel(tmpLevel);
}
}