Create new log4j2 logger config when setLevel is called for logger th… #3551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at is not configured. Seems that Configuration#getLoggerConfig(String) will return the parent configuration if th specified logger name is not explicitly configured in log4j2 configuration. And setting the log level will change some parent logger level. For that reason a new additive LoggerConfig has to be created for the specified logger and then added to the configuration. Fixes spring-projectsgh-3550
|
Thanks for the PR. I wanted to fix this in 1.2.x, and take a slightly different approach to accessing the logger config to make it harder for a similar problem to occur in the future. That made it easier to start from scratch rather than reworking these changes. Thanks for getting the ball rolling, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…at is not configured.
Seems that Configuration#getLoggerConfig(String) will return the parent configuration if th specified logger name is not explicitly configured in log4j2 configuration. And setting the log level will change some parent logger level.
For that reason a new additive LoggerConfig has to be created for the specified logger and then added to the configuration.
Fixes gh-3550