feat: auto-cleanup

[timdeschryver]

Closes #67

[tonivj5]

You're a magician. I was just trying to see what is happening. And the only thing that I have discovered is that if I disable removeAngularAttributes the error goes away... Very good catch see that the body is mantaining all templates 👍

UPDATE:
Very interesting, if you comment fixture.nativeElement.removeAttribute('id') in testing.library.ts. The document doesn't need the cleanup 🤔

[tonivj5]

Thinking about the fix, this error happens in every angular+jest setup, isn't it? 😕

[tonivj5]

I have found where happens the "bug"

It seems to be on the Angular side. It query for old roots to remove them, but, how the id is being remove, Angular isn't be able to find them 😿

So, this answers my last question! 👏

[timdeschryver]

Hmm interesting, thanks @tonivj5 !
Do you think we should still do this cleanup? I'm thinking of reverting the change to remove the root.

I'm definitely going to change the default in this version 😅

[timdeschryver]

(if you want you can create a PR)

[tonivj5]

Yes, if we use removeAngularAttributes the cleanup must be, because it prevents Angular from remove old roots. However, I think we should leave to Angular the task of remove its roots. I'm going to open a new PR proposing other cleanup (I think simpler) 👍

I'm definitely going to change the default in this version 😅

It could follow being enable by default, I guess it's enable by default to help in debug log (cleaner, I supose), isn't it?

[tonivj5]

Here is the PR #69 👍

[timdeschryver]

🎉 This PR is included in version 9.0.0-beta.2 🎉

The release is available on:

• npm package (@beta dist-tag)
• GitHub release

Your semantic-release bot 📦🚀