Changeset 100242 in webkit for trunk/Source/JavaScriptCore/heap/MarkStack.cpp

Timestamp:

Nov 14, 2011, 10:58:19 PM (14 years ago)

Author:

[email protected]

Message:

Weak reference harvesters should run to fixpoint
​https://bugs.webkit.org/show_bug.cgi?id=72346

Reviewed by Oliver Hunt.

• heap/Heap.cpp:

(JSC::Heap::markRoots):

• heap/ListableHandler.h:

(JSC::ListableHandler::next):
(JSC::ListableHandler::List::head):
(JSC::ListableHandler::List::removeNext):
(JSC::ListableHandler::List::removeAll):

• heap/MarkStack.cpp:

(JSC::MarkStackThreadSharedData::reset):
(JSC::SlotVisitor::harvestWeakReferences):

• heap/MarkStack.h:

(JSC::MarkStack::isEmpty):

File:

• trunk/Source/JavaScriptCore/heap/MarkStack.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/heap/MarkStack.cpp

@@ -272 +272 @@
     ASSERT(m_opaqueRoots.isEmpty());
 #endif
+    
+    m_weakReferenceHarvesters.removeAll();
 }
 
@@ -450 +452 @@
 void SlotVisitor::harvestWeakReferences()
 {
-    while (m_shared.m_weakReferenceHarvesters.hasNext())
-        m_shared.m_weakReferenceHarvesters.removeNext()->visitWeakReferences(*this);
+    for (WeakReferenceHarvester* current = m_shared.m_weakReferenceHarvesters.head(); current; current = current->next())
+        current->visitWeakReferences(*this);
 }