Changeset 100391 in webkit for trunk/Source/JavaScriptCore/runtime/JSGlobalData.h

Timestamp:

Nov 15, 2011, 6:53:09 PM (14 years ago)

Author:

Darin Adler

Message:

REGRESSION (r98887): ParserArena and Keywords leaking
​https://bugs.webkit.org/show_bug.cgi?id=72428

Reviewed by Sam Weinig.

• parser/Lexer.h: Made Keywords destructor public since OwnPtr and PassOwnPtr

need to be able to destroy it.

• parser/Parser.cpp:

(JSC::Parser::Parser): Use get now that parserArena is an OwnPtr.

• runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData): Use adoptPtr to initialize OwnPtr members.

• runtime/JSGlobalData.h: Make parserArena and keywords be OwnPtr.

File:

• trunk/Source/JavaScriptCore/runtime/JSGlobalData.h (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/JSGlobalData.h

@@ -220 +220 @@
         }
 
-        ParserArena* parserArena;
-        Keywords* keywords;
+        OwnPtr<ParserArena> parserArena;
+        OwnPtr<Keywords> keywords;
         Interpreter* interpreter;
 #if ENABLE(JIT)