Changeset 100417 in webkit for trunk/Source/JavaScriptCore/runtime/SymbolTable.h

Timestamp:

Nov 16, 2011, 12:05:40 AM (14 years ago)

Author:

Darin Adler

Message:

Fix some hash traits that don't derive from the base hash traits
​https://bugs.webkit.org/show_bug.cgi?id=72470

Reviewed by Filip Pizlo.

Hash traits structures need to derive from the base hash traits in
HashTraits.h, but some were not. This is needed for compatibility with
some additional traits we will be adding to make OwnPtr work with HashMap.

• runtime/Identifier.h: Make IdentifierMapIndexHashTraits derive from

HashTraits<int>. This enabled removal of all the members except for the
ones that control the empty value, because this is otherwise the same
as the standard int hash.

• runtime/SymbolTable.h: Changed SymbolTableIndexHashTraits to derive

from HashTraits<SymbolTableEntry> and removed redundant members.

File:

• trunk/Source/JavaScriptCore/runtime/SymbolTable.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/runtime/SymbolTable.h

@@ -33 +33 @@
 #include "UString.h"
 #include <wtf/AlwaysInline.h>
+#include <wtf/HashTraits.h>
 
 namespace JSC {
@@ -113 +114 @@
     };
 
-    struct SymbolTableIndexHashTraits {
-        typedef SymbolTableEntry TraitType;
-        static SymbolTableEntry emptyValue() { return SymbolTableEntry(); }
+    struct SymbolTableIndexHashTraits : HashTraits<SymbolTableEntry> {
         static const bool emptyValueIsZero = true;
         static const bool needsDestruction = false;