Changeset 100540 in webkit for trunk/Source/JavaScriptCore/interpreter/Interpreter.h

Timestamp:

Nov 16, 2011, 5:43:48 PM (14 years ago)

Author:

[email protected]

Message:

Some CachedCall cleanup, in preparation for reversing argument order.

Reviewed by Gavin Barraclough.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::stronglyVisitWeakReferences): A build fix for the interpreter,
so I can test it.

• interpreter/CachedCall.h:

(JSC::CachedCall::CachedCall): Renamed argCount to argumentCount because
we are not that desperate for character saving.

(JSC::CachedCall::setThis):
(JSC::CachedCall::setArgument): Adopted new 0-based argument indexing for
CallFrameClosure.

• interpreter/CallFrameClosure.h:

(JSC::CallFrameClosure::setThis):
(JSC::CallFrameClosure::setArgument):
(JSC::CallFrameClosure::resetCallFrame): Provide 0-based argument indexing,
with an explicit setter for 'this', since that's how most clients think.

• interpreter/Interpreter.cpp:

(JSC::Interpreter::prepareForRepeatCall):

• interpreter/Interpreter.h: Change argCount to argumentCountIncludingThis,

for clarity.

File:

• trunk/Source/JavaScriptCore/interpreter/Interpreter.h (modified) (1 diff)

trunk/Source/JavaScriptCore/interpreter/Interpreter.h

@@ -142 +142 @@
         enum ExecutionFlag { Normal, InitializeAndReturn };
 
-        CallFrameClosure prepareForRepeatCall(FunctionExecutable*, CallFrame*, JSFunction*, int argCount, ScopeChainNode*);
+        CallFrameClosure prepareForRepeatCall(FunctionExecutable*, CallFrame*, JSFunction*, int argumentCountIncludingThis, ScopeChainNode*);
         void endRepeatCall(CallFrameClosure&);
         JSValue execute(CallFrameClosure&);