Changeset 101283 in webkit for trunk/Source/JavaScriptCore/bytecode/CodeBlock.cpp

Timestamp:

Nov 28, 2011, 2:48:17 PM (14 years ago)

Author:

[email protected]

Message:

Either remove the GetMethod node from the DFG backend, or find a use for it
​https://bugs.webkit.org/show_bug.cgi?id=73178

Reviewed by Gavin Barraclough.

More testing seemed to imply that the GetMethod code was indeed not profitable
in any major test. So, it's probably best to just remove it.

• bytecode/CodeBlock.cpp:

(JSC::MethodCallLinkInfo::reset):

• dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

• dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

• dfg/DFGJITCompiler.h:
• dfg/DFGNode.h:

(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::hasHeapPrediction):

• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h:
• dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

• dfg/DFGRepatch.cpp:
• dfg/DFGRepatch.h:
• dfg/DFGSpeculativeJIT.h:
• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::compile):

File:

• trunk/Source/JavaScriptCore/bytecode/CodeBlock.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/bytecode/CodeBlock.cpp

@@ -2044 +2044 @@
     cachedFunction.clear();
     
-    if (jitType == JITCode::DFGJIT) {
-#if ENABLE(DFG_JIT)
-        repatchBuffer.relink(callReturnLocation, operationGetMethodOptimize);
-#else
-        ASSERT_NOT_REACHED();
-#endif
-    } else {
-        ASSERT(jitType == JITCode::BaselineJIT);
-        repatchBuffer.relink(callReturnLocation, cti_op_get_by_id_method_check);
-    }
+    ASSERT_UNUSED(jitType, jitType == JITCode::BaselineJIT);
+    
+    repatchBuffer.relink(callReturnLocation, cti_op_get_by_id_method_check);
 }