Changeset 101283 in webkit for trunk/Source/JavaScriptCore/dfg/DFGJITCompiler.cpp

Timestamp:

Nov 28, 2011, 2:48:17 PM (14 years ago)

Author:

[email protected]

Message:

Either remove the GetMethod node from the DFG backend, or find a use for it
​https://bugs.webkit.org/show_bug.cgi?id=73178

Reviewed by Gavin Barraclough.

More testing seemed to imply that the GetMethod code was indeed not profitable
in any major test. So, it's probably best to just remove it.

• bytecode/CodeBlock.cpp:

(JSC::MethodCallLinkInfo::reset):

• dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

• dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

• dfg/DFGJITCompiler.h:
• dfg/DFGNode.h:

(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::hasHeapPrediction):

• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h:
• dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

• dfg/DFGRepatch.cpp:
• dfg/DFGRepatch.h:
• dfg/DFGSpeculativeJIT.h:
• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::compile):

File:

• trunk/Source/JavaScriptCore/dfg/DFGJITCompiler.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/dfg/DFGJITCompiler.cpp

@@ -188 +188 @@
     }
     
-    m_codeBlock->addMethodCallLinkInfos(m_methodGets.size());
-    for (unsigned i = 0; i < m_methodGets.size(); ++i) {
-        MethodCallLinkInfo& info = m_codeBlock->methodCallLinkInfo(i);
-        info.cachedStructure.setLocation(linkBuffer.locationOf(m_methodGets[i].m_structToCompare));
-        info.cachedPrototypeStructure.setLocation(linkBuffer.locationOf(m_methodGets[i].m_protoStructToCompare));
-        info.cachedFunction.setLocation(linkBuffer.locationOf(m_methodGets[i].m_putFunction));
-        info.cachedPrototype.setLocation(linkBuffer.locationOf(m_methodGets[i].m_protoObj));
-        info.callReturnLocation = linkBuffer.locationOf(m_methodGets[i].m_slowCall);
-    }
-    
     MacroAssemblerCodeRef osrExitThunk = globalData()->getCTIStub(osrExitGenerationThunkGenerator);
     CodeLocationLabel target = CodeLocationLabel(osrExitThunk.code());