Changeset 101283 in webkit for trunk/Source/JavaScriptCore/dfg/DFGOperations.cpp

Timestamp:

Nov 28, 2011, 2:48:17 PM (14 years ago)

Author:

[email protected]

Message:

Either remove the GetMethod node from the DFG backend, or find a use for it
​https://bugs.webkit.org/show_bug.cgi?id=73178

Reviewed by Gavin Barraclough.

More testing seemed to imply that the GetMethod code was indeed not profitable
in any major test. So, it's probably best to just remove it.

• bytecode/CodeBlock.cpp:

(JSC::MethodCallLinkInfo::reset):

• dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

• dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

• dfg/DFGJITCompiler.h:
• dfg/DFGNode.h:

(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::hasHeapPrediction):

• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h:
• dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

• dfg/DFGRepatch.cpp:
• dfg/DFGRepatch.h:
• dfg/DFGSpeculativeJIT.h:
• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::compile):

File:

• trunk/Source/JavaScriptCore/dfg/DFGOperations.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/dfg/DFGOperations.cpp

@@ -318 +318 @@
     PropertySlot slot(baseValue);
     return JSValue::encode(baseValue.get(exec, *propertyName, slot));
-}
-
-J_FUNCTION_WRAPPER_WITH_RETURN_ADDRESS_ECI(operationGetMethodOptimize);
-EncodedJSValue DFG_OPERATION operationGetMethodOptimizeWithReturnAddress(ExecState* exec, JSCell* base, Identifier* propertyName, ReturnAddressPtr returnAddress)
-{
-    JSValue baseValue(base);
-    PropertySlot slot(baseValue);
-    JSValue result = baseValue.get(exec, *propertyName, slot);
-    
-    CodeBlock* codeBlock = exec->codeBlock();
-    MethodCallLinkInfo& methodInfo = codeBlock->getMethodCallLinkInfo(returnAddress);
-    if (methodInfo.seenOnce())
-        dfgRepatchGetMethod(exec, baseValue, *propertyName, slot, methodInfo);
-    else
-        methodInfo.setSeen();
-
-    return JSValue::encode(result);
 }