Changeset 10182 in webkit for trunk/JavaScriptCore/kjs/internal.h

Timestamp:

Aug 14, 2005, 9:41:47 AM (20 years ago)

Author:

darin

Message:

Reviewed by Maciej.

• fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4421 speed up JavaScript by inlining some label stack functions

• kjs/internal.h: Removed the copy constructor and assignment operator for LabelStack. They were unused, and the implementations had bugs; I removed them rather than fixing them. Also removed the clear function, since that was only needed to help the assignment operator share code with the destructor, and was not efficient enough for the destructor. (KJS::LabelStack::~LabelStack): Made this inline. Also used an efficient implementation that's nice and fast when the stack is empty, better than the old clear() function which used to keep updating and refetching "tos" each time through the loop. (KJS::LabelStack::pop): Made this inline.

• kjs/internal.cpp: Deleted the now-inline functions and the obsolete functions. Also deleted a commented-out line of code.

File:

• trunk/JavaScriptCore/kjs/internal.h (modified) (4 diffs)

trunk/JavaScriptCore/kjs/internal.h

@@ -140 +140 @@
     ~LabelStack();
 
-    LabelStack(const LabelStack &other);
-    LabelStack &operator=(const LabelStack &other);
-
     /**
      * If id is not empty and is not in the stack already, puts it on top of
@@ -166 +163 @@
     
   private:
+    LabelStack(const LabelStack &other);
+    LabelStack &operator=(const LabelStack &other);
+
     struct StackElem {
       Identifier id;
@@ -172 +172 @@
 
     StackElem *tos;
-    void clear();
     int iterationDepth;
     int switchDepth;
@@ -409 +408 @@
 #endif
 
+inline LabelStack::~LabelStack()
+{
+    StackElem *prev;
+    for (StackElem *e = tos; e; e = prev) {
+        prev = e->prev;
+        delete e;
+    }
+}
+
+inline void LabelStack::pop()
+{
+    if (StackElem *e = tos) {
+        tos = e->prev;
+        delete e;
+    }
+}
+
 } // namespace