Changeset 104338 in webkit for trunk/Source/JavaScriptCore/interpreter/Interpreter.h

Timestamp:

Jan 6, 2012, 2:15:31 PM (13 years ago)

Author:

[email protected]

Message:

Default HashTraits for Opcode don't work for Opcode = 0
​https://bugs.webkit.org/show_bug.cgi?id=75595

Reviewed by Oliver Hunt.

Removed the populating of the m_opcodeIDTable table in the
case where the OpcodeID and Opcode are the same (m_enabled is false).
Instead we just cast the one type to the other.

• interpreter/Interpreter.cpp:

(JSC::Interpreter::initialize):
(JSC::Interpreter::isOpcode):

• interpreter/Interpreter.h:

(JSC::Interpreter::getOpcodeID):

File:

• trunk/Source/JavaScriptCore/interpreter/Interpreter.h (modified) (1 diff)

trunk/Source/JavaScriptCore/interpreter/Interpreter.h

@@ -115 +115 @@
 #if ENABLE(COMPUTED_GOTO_INTERPRETER)
             ASSERT(isOpcode(opcode));
-            if (!m_enabled) {
-                OpcodeID result = static_cast<OpcodeID>(bitwise_cast<uintptr_t>(opcode));
-                ASSERT(result == m_opcodeIDTable.get(opcode));
-                return result;
-            }
+            if (!m_enabled)
+                return static_cast<OpcodeID>(bitwise_cast<uintptr_t>(opcode));
+
             return m_opcodeIDTable.get(opcode);
 #else