Changeset 10457 in webkit for trunk/JavaScriptCore/kjs/identifier.cpp

Timestamp:

Sep 3, 2005, 11:21:54 PM (20 years ago)

Author:

darin

Message:

Reviewed, tweaked and landed by Darin.

• another try at some of the Windows compilation fixes should fix these bugs: 4546, 4831, 4834, 4643, 4830, 4832, 4833, 4835

• kjs/collector.cpp: Add missing <setjmp.h> include.
• kjs/date_object.cpp: Fix broken copysign macro.
• kjs/dtoa.cpp: Move macro definitions down after all header includes.
• kjs/fast_malloc.cpp: Add missing <assert.h> and <stddef.h> includes.
• kjs/function.cpp: Remove broken isxdigit definition.
• kjs/grammar.y: Add a missing semicolon (and remove an excess one).
• kjs/identifier.cpp: Turn off AVOID_STATIC_CONSTRUCTORS because the placement new syntax doesn't seem to work in Visual C++ (I'm surprised to hear that, by the way).
• kjs/value.h: Made ValueImp's destructor virtual because otherwise pointers to ValueImp on the stack aren't right for garbage collection on Windows (don't think it works that way with gcc's virtual table scheme, but it's a harmless change).

File:

• trunk/JavaScriptCore/kjs/identifier.cpp (modified) (1 diff)

trunk/JavaScriptCore/kjs/identifier.cpp

@@ -26 +26 @@
 // runs at init time.
 
+#if !WIN32 // Visual C++ can't handle placement new, it seems.
 #define AVOID_STATIC_CONSTRUCTORS 1
+#endif
 
 #if AVOID_STATIC_CONSTRUCTORS