Changeset 105267 in webkit for trunk/Source/JavaScriptCore/wtf/Assertions.h

Timestamp:

Jan 18, 2012, 5:35:57 AM (13 years ago)

Author:

[email protected]

Message:

[Qt] Consolidate layout test crash logging
​https://bugs.webkit.org/show_bug.cgi?id=75088

Reviewed by Simon Hausmann.

Move backtrace generating logic into WTFReportBacktrace
and add a way to deinstall signal handlers if we know
that we have already printed the backtrace.

.:

• Source/qtwebkit-export.map:

Source/JavaScriptCore:

• JavaScriptCore.exp:
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
• wtf/Assertions.cpp:

(WTFLogLocker::WTFReportBacktrace):
(WTFLogLocker::WTFSetCrashHook):
(WTFLogLocker::WTFInvokeCrashHook):

• wtf/Assertions.h:

Tools:

• DumpRenderTree/qt/main.cpp:

(crashHandler):
(setupSignalHandlers):
(WTFCrashHook):
(main):

• WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:

(WTR::crashHandler):
(WTR::setupSignalHandlers):
(WTR::crashHook):
(WTR::InjectedBundle::platformInitialize):

File:

• trunk/Source/JavaScriptCore/wtf/Assertions.h (modified) (3 diffs)

trunk/Source/JavaScriptCore/wtf/Assertions.h

@@ -148 +148 @@
 WTF_EXPORT_PRIVATE void WTFReportBacktrace();
 
+typedef void (*WTFCrashHookFunction)();
+WTF_EXPORT_PRIVATE void WTFSetCrashHook(WTFCrashHookFunction);
+WTF_EXPORT_PRIVATE void WTFInvokeCrashHook();
+
 #ifdef __cplusplus
 }
@@ -164 +168 @@
 #define CRASH() do { \
     WTFReportBacktrace(); \
+    WTFInvokeCrashHook(); \
     *(int *)(uintptr_t)0xbbadbeef = 0; \
     __builtin_trap(); \
@@ -170 +175 @@
 #define CRASH() do { \
     WTFReportBacktrace(); \
+    WTFInvokeCrashHook(); \
     *(int *)(uintptr_t)0xbbadbeef = 0; \
     ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \