Changeset 108233 in webkit for trunk/Source/JavaScriptCore/parser/ASTBuilder.h

Timestamp:

Feb 20, 2012, 4:49:41 AM (13 years ago)

Author:

[email protected]

Message:

2012-02-120 Andy Wingo <​[email protected]>

Remove unused features from CodeFeatures
​https://bugs.webkit.org/show_bug.cgi?id=78804

Reviewed by Gavin Barraclough.

• parser/Nodes.h:
• parser/ASTBuilder.h:

(JSC::ClosureFeature):
(JSC::ASTBuilder::createFunctionBody):
(JSC::ASTBuilder::usesClosures):
Remove "ClosureFeature". Since we track captured variables more
precisely, this bit doesn't do us any good.

(JSC::AssignFeature):
(JSC::ASTBuilder::makeAssignNode):
(JSC::ASTBuilder::makePrefixNode):
(JSC::ASTBuilder::makePostfixNode):
(JSC::ASTBuilder::usesAssignment):
Similarly, remove AssignFeature. It is unused.

File:

• trunk/Source/JavaScriptCore/parser/ASTBuilder.h (modified) (5 diffs)

trunk/Source/JavaScriptCore/parser/ASTBuilder.h

@@ -266 +266 @@
     FunctionBodyNode* createFunctionBody(int lineNumber, bool inStrictContext)
     {
-        usesClosures();
         return FunctionBodyNode::create(m_globalData, lineNumber, inStrictContext);
     }
@@ -625 +624 @@
     void usesThis() { m_scope.m_features |= ThisFeature; }
     void usesCatch() { m_scope.m_features |= CatchFeature; }
-    void usesClosures() { m_scope.m_features |= ClosureFeature; }
     void usesArguments() { m_scope.m_features |= ArgumentsFeature; }
-    void usesAssignment() { m_scope.m_features |= AssignFeature; }
     void usesWith() { m_scope.m_features |= WithFeature; }
     void usesEval() 
@@ -905 +902 @@
 ExpressionNode* ASTBuilder::makeAssignNode(int lineNumber, ExpressionNode* loc, Operator op, ExpressionNode* expr, bool locHasAssignments, bool exprHasAssignments, int start, int divot, int end)
 {
-    usesAssignment();
     if (!loc->isLocation())
         return new (m_globalData) AssignErrorNode(lineNumber, loc, op, expr, divot, divot - start, end - divot);
@@ -943 +939 @@
 ExpressionNode* ASTBuilder::makePrefixNode(int lineNumber, ExpressionNode* expr, Operator op, int start, int divot, int end)
 {
-    usesAssignment();
     if (!expr->isLocation())
         return new (m_globalData) PrefixErrorNode(lineNumber, expr, op, divot, divot - start, end - divot);
@@ -966 +961 @@
 ExpressionNode* ASTBuilder::makePostfixNode(int lineNumber, ExpressionNode* expr, Operator op, int start, int divot, int end)
 {
-    usesAssignment();
     if (!expr->isLocation())
         return new (m_globalData) PostfixErrorNode(lineNumber, expr, op, divot, divot - start, end - divot);