Changeset 108553 in webkit for trunk/Source/JavaScriptCore/wtf/StdLibExtras.h

Timestamp:

Feb 22, 2012, 2:26:22 PM (13 years ago)

Author:

[email protected]

Message:

Allocations from CopiedBlocks should always be 8-byte aligned
​https://bugs.webkit.org/show_bug.cgi?id=79271

Reviewed by Geoffrey Garen.

• heap/CopiedAllocator.h:

(JSC::CopiedAllocator::allocate):

• heap/CopiedBlock.h: Changed to add padding so that the start of the payload is always

guaranteed to be 8 byte aligned on both 64- and 32-bit platforms.
(CopiedBlock):

• heap/CopiedSpace.cpp: Changed all assertions of isPointerAligned to is8ByteAligned.

(JSC::CopiedSpace::tryAllocateOversize):
(JSC::CopiedSpace::getFreshBlock):

• heap/CopiedSpaceInlineMethods.h:

(JSC::CopiedSpace::allocateFromBlock):

• runtime/JSArray.h:

(ArrayStorage): Added padding for ArrayStorage to make sure that it is always 8 byte
aligned on both 64- and 32-bit platforms.

• wtf/StdLibExtras.h:

(WTF::is8ByteAligned): Added new utility function that functions similarly to the
way isPointerAligned does, but it just always checks for 8 byte alignment.
(WTF):

File:

• trunk/Source/JavaScriptCore/wtf/StdLibExtras.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/wtf/StdLibExtras.h

@@ -115 +115 @@
 }
 
+inline bool is8ByteAligned(void* p)
+{
+    return !((uintptr_t)(p) & (sizeof(double) - 1));
+}
+
 /*
  * C++'s idea of a reinterpret_cast lacks sufficient cojones.
@@ -293 +298 @@
 using WTF::KB;
 using WTF::isPointerAligned;
+using WTF::is8ByteAligned;
 using WTF::binarySearch;
 using WTF::bitwise_cast;