Changeset 10857 in webkit for trunk/JavaScriptCore/kjs/property_map.cpp

Timestamp:

Oct 15, 2005, 5:46:25 PM (20 years ago)

Author:

mjs

Message:

Reverted fix for this bug, because it was part of a time range that caused a performance
regression:

<rdar://problem/4260481> Remove Reference type from JavaScriptCore

File:

• trunk/JavaScriptCore/kjs/property_map.cpp (modified) (8 diffs)

trunk/JavaScriptCore/kjs/property_map.cpp

@@ -26 +26 @@
 #include "object.h"
 #include "protect.h"
-#include "IdentifierSequencedSet.h"
+#include "reference_list.h"
 
 #include <algorithm>
@@ -75 +75 @@
 
 // lastIndexUsed is an ever-increasing index used to identify the order items
-// were inserted into the property map. It's vital that getEnumerablePropertyNames
+// were inserted into the property map. It's vital that addEnumerablesToReferenceList
 // return the properties in the order they were added for compatibility with other
 // browsers' JavaScript implementations.
@@ -567 +567 @@
 }
 
-void PropertyMap::getEnumerablePropertyNames(IdentifierSequencedSet& propertyNames) const
+void PropertyMap::addEnumerablesToReferenceList(ReferenceList &list, ObjectImp *base) const
 {
     if (!_table) {
@@ -573 +573 @@
         UString::Rep *key = _singleEntry.key;
         if (key && !(_singleEntry.attributes & DontEnum))
-            propertyNames.insert(Identifier(key));
+            list.append(Reference(base, Identifier(key)));
 #endif
         return;
@@ -599 +599 @@
     qsort(sortedEnumerables, p - sortedEnumerables, sizeof(sortedEnumerables[0]), comparePropertyMapEntryIndices);
 
-    // Put the keys of the sorted entries into the list.
+    // Put the keys of the sorted entries into the reference list.
     Entry **q = sortedEnumerables;
-    while (q != p) {
-        propertyNames.insert(Identifier(q[0]->key));
-        ++q;
-    }
+    while (q != p)
+        list.append(Reference(base, Identifier((*q++)->key)));
 
     // Deallocate the buffer.
@@ -611 +609 @@
 }
 
-void PropertyMap::getSparseArrayPropertyNames(IdentifierSequencedSet& propertyNames) const
+void PropertyMap::addSparseArrayPropertiesToReferenceList(ReferenceList &list, ObjectImp *base) const
 {
     if (!_table) {
@@ -621 +619 @@
             k.toUInt32(&fitsInUInt32);
             if (fitsInUInt32)
-                propertyNames.insert(Identifier(key));
+                list.append(Reference(base, Identifier(key)));
         }
 #endif
@@ -636 +634 @@
             k.toUInt32(&fitsInUInt32);
             if (fitsInUInt32)
-                propertyNames.insert(Identifier(key));
+                list.append(Reference(base, Identifier(key)));
         }
     }