Changeset 109172 in webkit for trunk/Source/JavaScriptCore/dfg/DFGOperations.cpp

Timestamp:

Feb 28, 2012, 5:13:08 PM (13 years ago)

Author:

[email protected]

Message:

Some run-javascriptcore-tests broken for 32-bit debug
​https://bugs.webkit.org/show_bug.cgi?id=79844

Rubber stamped by Oliver Hunt.

These assertions are just plain wrong for 32-bit. We could either have a massive
assertion that depends on value representation, that has to be changed every
time we change the JITs, resulting in a bug tail of debug-mode crashes, or we
could get rid of the assertions. I pick the latter.

• dfg/DFGOperations.cpp:
• jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

File:

• trunk/Source/JavaScriptCore/dfg/DFGOperations.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/dfg/DFGOperations.cpp

@@ -740 +740 @@
     JSValue src1 = JSValue::decode(encodedOp1);
     JSValue src2 = JSValue::decode(encodedOp2);
-    
-    ASSERT((src1.isCell() && src2.isCell())
-           || src1.isDouble() || src2.isDouble());
     
     return JSValue::strictEqual(exec, src1, src2);