Changeset 111358 in webkit for trunk/Source/JavaScriptCore/parser/SourceCode.h

Timestamp:

Mar 19, 2012, 10:24:24 PM (13 years ago)

Author:

[email protected]

Message:

Do not copy the script source in the SourceProvider, just reference the existing string
​https://bugs.webkit.org/show_bug.cgi?id=81466

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

• parser/SourceCode.h: Remove the unused, and incorrect, function data().
• parser/SourceProvider.h: Add OVERRIDE for clarity.

Source/WebCore:

Instead of creating a copy of the string with 16bits characters, we just return
a shared StringImpl.

• bindings/js/CachedScriptSourceProvider.h:
• bindings/js/StringSourceProvider.h:

File:

• trunk/Source/JavaScriptCore/parser/SourceCode.h (modified) (1 diff)

trunk/Source/JavaScriptCore/parser/SourceCode.h

@@ -73 +73 @@
         int startOffset() const { return m_startChar; }
         int endOffset() const { return m_endChar; }
-        const UChar* data() const
-        {
-            ASSERT(m_provider->data());
-            return m_provider->data()->characters16() + m_startChar;
-        }
         int length() const { return m_endChar - m_startChar; }