Changeset 111433 in webkit for trunk/Source/JavaScriptCore/runtime/Operations.cpp

Timestamp:

Mar 20, 2012, 1:22:57 PM (13 years ago)

Author:

[email protected]

Message:

Cache the type string of JavaScript object
​https://bugs.webkit.org/show_bug.cgi?id=81446

Patch by Benjamin Poulain <​[email protected]> on 2012-03-20
Reviewed by Geoffrey Garen.

Instead of creating the JSString every time, we create
lazily the strings in JSGlobalData.

This avoid the construction of the StringImpl and of the JSString,
which gives some performance improvements.

• runtime/CommonIdentifiers.h:
• runtime/JSValue.cpp:

(JSC::JSValue::toStringSlowCase):

• runtime/Operations.cpp:

(JSC::jsTypeStringForValue):

• runtime/SmallStrings.cpp:

(JSC::SmallStrings::SmallStrings):
(JSC::SmallStrings::finalizeSmallStrings):
(JSC::SmallStrings::initialize):
(JSC):

• runtime/SmallStrings.h:

(SmallStrings):

File:

• trunk/Source/JavaScriptCore/runtime/Operations.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/Operations.cpp

@@ -59 +59 @@
 JSValue jsTypeStringForValue(CallFrame* callFrame, JSValue v)
 {
+    JSGlobalData& globalData = callFrame->globalData();
     if (v.isUndefined())
-        return jsNontrivialString(callFrame, "undefined");
+        return globalData.smallStrings.undefinedString(&globalData);
     if (v.isBoolean())
-        return jsNontrivialString(callFrame, "boolean");
+        return globalData.smallStrings.booleanString(&globalData);
     if (v.isNumber())
-        return jsNontrivialString(callFrame, "number");
+        return globalData.smallStrings.numberString(&globalData);
     if (v.isString())
-        return jsNontrivialString(callFrame, "string");
+        return globalData.smallStrings.stringString(&globalData);
     if (v.isObject()) {
         // Return "undefined" for objects that should be treated
         // as null when doing comparisons.
         if (asObject(v)->structure()->typeInfo().masqueradesAsUndefined())
-            return jsNontrivialString(callFrame, "undefined");
+            return globalData.smallStrings.undefinedString(&globalData);
         CallData callData;
         JSObject* object = asObject(v);
         if (object->methodTable()->getCallData(object, callData) != CallTypeNone)
-            return jsNontrivialString(callFrame, "function");
+            return globalData.smallStrings.functionString(&globalData);
     }
-    return jsNontrivialString(callFrame, "object");
+    return globalData.smallStrings.objectString(&globalData);
 }