Changeset 11213 in webkit for trunk/JavaScriptCore/kjs/internal.h

Timestamp:

Nov 15, 2005, 5:45:12 PM (20 years ago)

Author:

ggaren

Message:

Reviewed by mjs.

• Fixed <rdar://problem/4342216> Installer crash in KJS::ValueImp::marked() when garbage collector runs inside call to ConstantValues::init()

I took responsibility for initializing and marking ConstantValues away
from InterpreterImp, since it's possible to reference such a value
before any interpreter has been created and after the last interpreter
has been destroyed.

InterpreterImp::lock now initializes ConstantValues. It's a good
place for the initialization because you have to call it before
creating any objects. Since ::lock can be called more than once,
I added a check in ConstantValues::init to ensure that it executes
only once.

Collector:collect is now responsible for marking ConstantValues.

We no longer clear the ConstantValues since we can't guarantee that no
one has a reference to them.

FIXME: This is hackery. The long-term plan is to make ConstantValues
use immediate values that require no initialization.

• ChangeLog:
• kjs/collector.cpp: (KJS::Collector::collect):
• kjs/internal.cpp: (KJS::InterpreterImp::InterpreterImp): (KJS::InterpreterImp::lock): (KJS::InterpreterImp::clear): (KJS::InterpreterImp::mark):
• kjs/internal.h:
• kjs/value.cpp: (KJS::ConstantValues::initIfNeeded):
• kjs/value.h:

File:

• trunk/JavaScriptCore/kjs/internal.h (modified) (1 diff)

trunk/JavaScriptCore/kjs/internal.h

@@ -247 +247 @@
     friend class Collector;
   public:
-    static void globalInit();
-    static void globalClear();
-
     InterpreterImp(Interpreter *interp, ObjectImp *glob);
     ~InterpreterImp();