Changeset 11331 in webkit for trunk/JavaScriptCore/kjs/date_object.cpp

Timestamp:

Nov 29, 2005, 2:33:22 AM (20 years ago)

Author:

eseidel

Message:

Bug #: 5514
Submitted by: mitz
Reviewed by: ggaren

Date conversion to local time gets the DST flag wrong sometimes
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5514

• kjs/date_object.cpp: (KJS::isTime_tSigned): (KJS::DateProtoFuncImp::callAsFunction):

File:

• trunk/JavaScriptCore/kjs/date_object.cpp (modified) (2 diffs)

trunk/JavaScriptCore/kjs/date_object.cpp

@@ -470 +470 @@
 }
 
+static bool isTime_tSigned()
+{
+    time_t minusOne = (time_t)(-1);
+    return minusOne < 0;
+}
+
 ValueImp *DateProtoFuncImp::callAsFunction(ExecState *exec, ObjectImp *thisObj, const List &args)
 {
@@ -523 +529 @@
   // check whether time value is outside time_t's usual range
   // make the necessary transformations if necessary
+  static bool time_tIsSigned = isTime_tSigned();
+  static double time_tMin = (time_tIsSigned ? - (double)(1ULL << (8 * sizeof(time_t) - 1)) : 0);
+  static double time_tMax = (time_tIsSigned ? (1ULL << 8 * sizeof(time_t) - 1) - 1 : 2 * (double)(1ULL << 8 * sizeof(time_t) - 1) - 1);
   int realYearOffset = 0;
   double milliOffset = 0.0;
   double secs = floor(milli / msPerSecond);
 
-  if (milli < 0 || milli >= timeFromYear(2038)) {
+  if (secs < time_tMin || secs > time_tMax) {
     // ### ugly and probably not very precise
     int realYear = yearFromTime(milli);