Changeset 113355 in webkit for trunk/Source/JavaScriptCore/Target.pri

Timestamp:

Apr 5, 2012, 12:30:13 PM (13 years ago)

Author:

[email protected]

Message:

Make something faster than JSStringBuilder for joining an array of JSValue
​https://bugs.webkit.org/show_bug.cgi?id=83180

Patch by Benjamin Poulain <​[email protected]> on 2012-04-05
Reviewed by Geoffrey Garen.

This patch add the class JSStringJoiner optimized for join() operations.

This class makes stricter constraints than JSStringBuilder in order avoid
memory allocations.

In the best case, the class allocate memory only twice:
-Allocate an array to keep a list of UString to join.
-Allocate the final string.

We also avoid the conversion from 8bits strings to 16bits strings since
they are costly and unlikly to help for subsequent calls.

• CMakeLists.txt:
• GNUmakefile.list.am:
• JavaScriptCore.gypi:
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
• JavaScriptCore.xcodeproj/project.pbxproj:
• Target.pri:
• runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):

• runtime/JSStringJoiner.cpp: Added.

(JSC):
(JSC::appendStringToData):
(JSC::joinStrings):
(JSC::JSStringJoiner::build):

• runtime/JSStringJoiner.h: Added.

(JSC):
(JSStringJoiner):
(JSC::JSStringJoiner::JSStringJoiner):
(JSC::JSStringJoiner::append):

File:

• trunk/Source/JavaScriptCore/Target.pri (modified) (1 diff)

trunk/Source/JavaScriptCore/Target.pri

@@ -191 +191 @@
     runtime/JSStaticScopeObject.cpp \
     runtime/JSString.cpp \
+    runtime/JSStringJoiner.cpp \
     runtime/JSValue.cpp \
     runtime/JSVariableObject.cpp \