Changeset 11472 in webkit for trunk/JavaScriptCore/kjs/identifier.h

Timestamp:

Dec 6, 2005, 1:21:15 AM (19 years ago)

Author:

mjs

Message:

JavaScriptCore:

Reviewed by Eric.

• add PassRefPtr, a smart pointer class that works in conjunction with RefPtr but has transfer-of-ownership semantics
• apply RefPtr and PassRefPtr to UString
• cleaned up UString a little so that it doesn't need to have so many friend classes

• JavaScriptCore.xcodeproj/project.pbxproj:
• kjs/identifier.cpp: (KJS::Identifier::add):
• kjs/identifier.h: (KJS::Identifier::Identifier): (KJS::Identifier::equal):
• kjs/property_map.cpp: (KJS::PropertyMap::get): (KJS::PropertyMap::getLocation): (KJS::PropertyMap::put): (KJS::PropertyMap::remove):
• kjs/ustring.cpp: (KJS::UCharReference::operator=): (KJS::UCharReference::ref): (KJS::UString::Rep::createCopying): (KJS::UString::Rep::create): (KJS::UString::usedCapacity): (KJS::UString::usedPreCapacity): (KJS::UString::expandCapacity): (KJS::UString::expandPreCapacity): (KJS::UString::UString): (KJS::UString::spliceSubstringsWithSeparators): (KJS::UString::append): (KJS::UString::operator=): (KJS::UString::toStrictUInt32): (KJS::UString::substr): (KJS::UString::copyForWriting): (KJS::operator==):
• kjs/ustring.h: (KJS::UString::UString): (KJS::UString::~UString): (KJS::UString::data): (KJS::UString::isNull): (KJS::UString::isEmpty): (KJS::UString::size): (KJS::UString::rep):
• kxmlcore/RefPtr.h: (KXMLCore::RefPtr::RefPtr): (KXMLCore::RefPtr::operator*): (KXMLCore::::operator): (KXMLCore::operator==): (KXMLCore::operator!=): (KXMLCore::static_pointer_cast): (KXMLCore::const_pointer_cast):

WebCore:

Reviewed by Eric.

• add PassRefPtr, a smart pointer class that works in conjunction with RefPtr but has transfer-of-ownership semantics
• apply RefPtr and PassRefPtr to UString

• khtml/ecma/kjs_binding.cpp: (KJS::UString::UString):

File:

• trunk/JavaScriptCore/kjs/identifier.h (modified) (2 diffs)

trunk/JavaScriptCore/kjs/identifier.h

@@ -35 +35 @@
         Identifier(const char *s) : _ustring(add(s)) { }
         Identifier(const UChar *s, int length) : _ustring(add(s, length)) { }
-        explicit Identifier(const UString &s) : _ustring(add(s.rep)) { }
+        explicit Identifier(UString::Rep *rep) : _ustring(add(rep)) { } 
+        explicit Identifier(const UString &s) : _ustring(add(s.rep())) { }
         
         const UString &ustring() const { return _ustring; }
@@ -73 +74 @@
 
         static bool equal(const Identifier &a, const Identifier &b)
-            { return a._ustring.rep == b._ustring.rep; }
+            { return a._ustring.rep() == b._ustring.rep(); }
         static bool equal(const Identifier &a, const char *b)
-            { return equal(a._ustring.rep, b); }
+            { return equal(a._ustring.rep(), b); }
         
         static UString::Rep *add(const char *);