Changeset 11496 in webkit for trunk/JavaScriptCore/kjs/ustring.cpp

Timestamp:

Dec 8, 2005, 10:19:28 AM (19 years ago)

Author:

mjs

Message:

Reviewed by John.

• fix major memory leak and resultant slowdown on JavaScript iBench from my PassRefPtr changes

• kjs/ustring.cpp: (KJS::UString::Rep::create): I forgot to change one of the two overloads to create with a refcount of 0 instead of 1 (the smart pointer then bumps it. But instead of changing it, I changed both to start with a refcounter of 1 and use PassRefPtr::adopt to adopt the initial refcount, this may be a hair more efficient.

• made the assignment operators for smart pointers inline because Shark said so

• kxmlcore/PassRefPtr.h: (KXMLCore::::operator=):
• kxmlcore/RefPtr.h: (KXMLCore::::operator=):

File:

• trunk/JavaScriptCore/kjs/ustring.cpp (modified) (3 diffs)

trunk/JavaScriptCore/kjs/ustring.cpp

@@ -190 +190 @@
   r->offset = 0;
   r->len = l;
-  r->rc = 0;
+  r->rc = 1;
   r->_hash = 0;
   r->isIdentifier = 0;
@@ -199 +199 @@
   r->usedPreCapacity = 0;
   r->preCapacity = 0;
-  return r;
+  // steal the single reference this Rep was created with
+  return PassRefPtr<Rep>::adopt(r);
 }
 
@@ -227 +228 @@
   r->usedPreCapacity = 0;
   r->preCapacity = 0;
-  return r;
+  // steal the single reference this Rep was created with
+  return PassRefPtr<Rep>::adopt(r);
 }