Changeset 116785 in webkit for trunk/Source/JavaScriptCore/heap/MarkStack.cpp

Timestamp:

May 11, 2012, 10:57:17 AM (13 years ago)

Author:

[email protected]

Message:

Fix crash seen when running with libgmalloc
<rdar://problem/11435411>
​https://bugs.webkit.org/show_bug.cgi?id=86232

Reviewed by Gavin Barraclough.

• heap/MarkStack.cpp:

(JSC::MarkStackThreadSharedData::markingThreadMain):
Don't delete the SlotVisitor before the ParallelModeEnabler has had a chance to run its
destructor.

File:

• trunk/Source/JavaScriptCore/heap/MarkStack.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/heap/MarkStack.cpp

@@ -229 +229 @@
 {
     WTF::registerGCThread();
-    ParallelModeEnabler enabler(*slotVisitor);
-    slotVisitor->drainFromShared(SlotVisitor::SlaveDrain);
+    {
+        ParallelModeEnabler enabler(*slotVisitor);
+        slotVisitor->drainFromShared(SlotVisitor::SlaveDrain);
+    }
     delete slotVisitor;
 }