Changeset 11719 in webkit for trunk/JavaScriptCore/kjs/testkjs.cpp

Timestamp:

Dec 21, 2005, 4:55:34 PM (19 years ago)

Author:

ggaren

Message:

Reviewed by Darin.

Removed evil hack for determining if a type is an integer, replaced
with template metaprogramming.

• JavaScriptCore.xcodeproj/project.pbxproj: Set tab size to 2 for testkjs.cpp
• kjs/testkjs.cpp: (main): Inserted asserts to test IsInteger. FIXME: Move these to KXMLCore unit tests directory when we create one.
• kxmlcore/HashTraits.h: (KXMLCore::): Added IsInteger class for querying types.

File:

• trunk/JavaScriptCore/kjs/testkjs.cpp (modified) (3 diffs)

trunk/JavaScriptCore/kjs/testkjs.cpp

@@ -27 +27 @@
 #include <string.h>
 
+#include "HashTraits.h"
 #include "value.h"
 #include "object.h"
@@ -35 +36 @@
 
 using namespace KJS;
+using namespace KXMLCore;
 
 class TestFunctionImp : public JSObject {
@@ -106 +108 @@
   {
     JSLock lock;
-
+    
+    // Unit tests for KXMLCore::IsInteger. Don't have a better place for them now.
+    // FIXME: move these once we create a unit test directory for KXMLCore.
+    assert(IsInteger<bool>::value);
+    assert(IsInteger<char>::value);
+    assert(IsInteger<signed char>::value);
+    assert(IsInteger<unsigned char>::value);
+    assert(IsInteger<short>::value);
+    assert(IsInteger<unsigned short>::value);
+    assert(IsInteger<int>::value);
+    assert(IsInteger<unsigned int>::value);
+    assert(IsInteger<long>::value);
+    assert(IsInteger<unsigned long>::value);
+    assert(IsInteger<long long>::value);
+    assert(IsInteger<unsigned long long>::value);
+
+    assert(!IsInteger<char *>::value);
+    assert(!IsInteger<const char *>::value);
+    assert(!IsInteger<volatile char *>::value);
+    assert(!IsInteger<double>::value);
+    assert(!IsInteger<float>::value);
+    assert(!IsInteger<GlobalImp>::value);
+    
     JSObject *global(new GlobalImp());