Changeset 117193 in webkit for trunk/Source/JavaScriptCore/interpreter/Interpreter.cpp

Timestamp:

May 15, 2012, 5:21:00 PM (13 years ago)

Author:

[email protected]

Message:

Make error information available even if all we have is line number information.
​https://bugs.webkit.org/show_bug.cgi?id=86547

Reviewed by Filip Pizlo.

We don't need expression information to generate useful line, file, and stack information,
so only require that we have line number info available.

• interpreter/Interpreter.cpp:

(JSC::Interpreter::throwException):

• runtime/Executable.h:

(JSC):

File:

• trunk/Source/JavaScriptCore/interpreter/Interpreter.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/interpreter/Interpreter.cpp

@@ -1024 +1024 @@
             appendSourceToError(callFrame, static_cast<ErrorInstance*>(exception), bytecodeOffset);
 
-        // Using hasExpressionInfo to imply we are interested in rich exception info.
-        if (codeBlock->hasExpressionInfo() && !hasErrorInfo(callFrame, exception)) {
-            ASSERT(codeBlock->hasLineInfo());
+        if (codeBlock->hasLineInfo() && !hasErrorInfo(callFrame, exception)) {
             // FIXME: should only really be adding these properties to VM generated exceptions,
             // but the inspector currently requires these for all thrown objects.