Changeset 118019 in webkit for trunk/Source/JavaScriptCore/runtime/JSGlobalData.cpp

Timestamp:

May 22, 2012, 12:17:57 PM (13 years ago)

Author:

[email protected]

Message:

GC allocation trigger should be tuned to system RAM
​https://bugs.webkit.org/show_bug.cgi?id=87039

Reviewed by Darin Adler.

../JavaScriptCore:

This helps avoid OOM crashes on small platforms, and helps avoid "too much GC"
performance issues on big platforms.

• heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::collect):

• heap/Heap.h:

(Heap): GC balances between a fixed minimum and a proportional multiplier,
which are limited based on system RAM.

• runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::createContextGroup):
(JSC::JSGlobalData::create):
(JSC::JSGlobalData::createLeaked):

• runtime/JSGlobalData.h:

(JSGlobalData): Renamed HeapSize to HeapType because the exact size is
influenced by the heap type, but not determined by it.

../WTF:

Added a helper function for measuring system RAM.

• GNUmakefile.list.am:
• WTF.gypi:
• WTF.pro:
• WTF.vcproj/WTF.vcproj:
• WTF.xcodeproj/project.pbxproj:
• wtf/AmountOfRAM.cpp: Added.

(WTF):
(WTF::computeAmountOfRAM):
(WTF::amountOfRAM):

• wtf/AmountOfRAM.h: Added.

(WTF):

• wtf/CMakeLists.txt:
• wtf/StdLibExtras.h:

(WTF):

File:

• trunk/Source/JavaScriptCore/runtime/JSGlobalData.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/runtime/JSGlobalData.cpp

@@ -119 +119 @@
 #endif
 
-JSGlobalData::JSGlobalData(GlobalDataType globalDataType, ThreadStackType threadStackType, HeapSize heapSize)
-    : heap(this, heapSize)
+JSGlobalData::JSGlobalData(GlobalDataType globalDataType, ThreadStackType threadStackType, HeapType heapType)
+    : heap(this, heapType)
     , globalDataType(globalDataType)
     , clientData(0)
@@ -291 +291 @@
 }
 
-PassRefPtr<JSGlobalData> JSGlobalData::createContextGroup(ThreadStackType type, HeapSize heapSize)
-{
-    return adoptRef(new JSGlobalData(APIContextGroup, type, heapSize));
-}
-
-PassRefPtr<JSGlobalData> JSGlobalData::create(ThreadStackType type, HeapSize heapSize)
-{
-    return adoptRef(new JSGlobalData(Default, type, heapSize));
-}
-
-PassRefPtr<JSGlobalData> JSGlobalData::createLeaked(ThreadStackType type, HeapSize heapSize)
-{
-    return create(type, heapSize);
+PassRefPtr<JSGlobalData> JSGlobalData::createContextGroup(ThreadStackType type, HeapType heapType)
+{
+    return adoptRef(new JSGlobalData(APIContextGroup, type, heapType));
+}
+
+PassRefPtr<JSGlobalData> JSGlobalData::create(ThreadStackType type, HeapType heapType)
+{
+    return adoptRef(new JSGlobalData(Default, type, heapType));
+}
+
+PassRefPtr<JSGlobalData> JSGlobalData::createLeaked(ThreadStackType type, HeapType heapType)
+{
+    return create(type, heapType);
 }