Changeset 118646 in webkit for trunk/Source/JavaScriptCore/heap/Heap.cpp

Timestamp:

May 27, 2012, 9:56:01 PM (13 years ago)

Author:

[email protected]

Message:

Weak pointer finalization should be lazy
​https://bugs.webkit.org/show_bug.cgi?id=87599

Reviewed by Darin Adler.

• heap/Heap.cpp:

(JSC::Heap::collect): Don't force immediate finalization -- it will
happen lazily.

• heap/MarkedBlock.cpp:

(JSC::MarkedBlock::sweep): Sweep a block's weak set when sweeping the
block. The weak set may not have been swept yet, and this is our last
chance to run weak finalizers before we recycle the memory they reference.

• heap/MarkedBlock.h:
• heap/MarkedSpace.cpp:

(JSC::MarkedBlock::sweepWeakSets):

• heap/MarkedSpace.h:

(JSC::MarkedSpace::sweepWeakSets): Nixed sweepWeakSets because it's unused
now.

File:

• trunk/Source/JavaScriptCore/heap/Heap.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/heap/Heap.cpp

@@ -688 +688 @@
     {
         GCPHASE(FinalizeWeakHandles);
-        m_objectSpace.sweepWeakSets();
         m_globalData->smallStrings.finalizeSmallStrings();
     }