Changeset 11920 in webkit for trunk/JavaScriptCore/kjs/function.cpp

Timestamp:

Jan 6, 2006, 3:51:00 PM (19 years ago)

Author:

mjs

Message:

Reviewed by Darin.

• miscellaneous changes for 4% speedup on the JavaScript iBench ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6396

Changes mostly thanks to Maks Orlovich, tweaked a little by me.

• kjs/create_hash_table: Use the same hash as the one used buy Identifier.
• kjs/function.cpp: (KJS::FunctionImp::processParameters): Use the new List::copyFrom (KJS::ActivationImp::ActivationImp): track variable while iterating
• kjs/internal.cpp: (KJS::StringImp::toObject): create StringInstance directly
• kjs/list.cpp: (KJS::List::copy): implement in terms of copyFrom (KJS::List::copyFrom): more efficient way to copy in another list
• kjs/list.h:
• kjs/lookup.cpp: (keysMatch): updated to work with identifier hash (findEntry): ditto (Lookup::findEntry): ditto (Lookup::find): ditto
• kjs/lookup.h:

File:

• trunk/JavaScriptCore/kjs/function.cpp (modified) (3 diffs)

trunk/JavaScriptCore/kjs/function.cpp

@@ -182 +182 @@
     ListIterator it = args.begin();
     Parameter *p = param;
+    JSValue  *v = *it;
     while (p) {
       if (it != args.end()) {
@@ -188 +189 @@
         printInfo(exec,"to", *it);
 #endif
-        variable->put(exec, p->name, *it);
-        it++;
+        variable->put(exec, p->name, v);
+        v = ++it;
       } else
         variable->put(exec, p->name, jsUndefined());
@@ -486 +487 @@
     : _function(function), _arguments(true), _argumentsObject(0)
 {
-  _arguments = arguments.copy();
+  _arguments.copyFrom(arguments);
   // FIXME: Do we need to support enumerating the arguments property?
 }