Changeset 119909 in webkit for trunk/Source/JavaScriptCore/heap/Heap.cpp

Timestamp:

Jun 9, 2012, 10:34:30 AM (13 years ago)

Author:

[email protected]

Message:

Unreviewed, rolling back in part2 of r118646.

This patch removes eager finalization.

Weak pointer finalization should be lazy
​https://bugs.webkit.org/show_bug.cgi?id=87599

Reviewed by Sam Weinig.

• heap/Heap.cpp:

(JSC::Heap::collect): Don't finalize eagerly -- we'll do it lazily.

• heap/MarkedBlock.cpp:

(JSC::MarkedBlock::sweep): Do sweep weak sets when sweeping a block,
since we won't get another chance.

• heap/MarkedBlock.h:

(JSC::MarkedBlock::sweepWeakSet):

• heap/MarkedSpace.cpp:

(MarkedSpace::WeakSetSweep):

• heap/MarkedSpace.h:

(JSC::MarkedSpace::sweepWeakSets): Removed now-unused code.

File:

• trunk/Source/JavaScriptCore/heap/Heap.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/heap/Heap.cpp

@@ -735 +735 @@
 
     {
-        GCPHASE(FinalizeWeakHandles);
-        m_objectSpace.sweepWeakSets();
+        GCPHASE(finalizeSmallStrings);
         m_globalData->smallStrings.finalizeSmallStrings();
     }