Changeset 11999 in webkit for trunk/JavaScriptCore/kjs/number_object.cpp

Timestamp:

Jan 11, 2006, 8:47:02 AM (19 years ago)

Author:

darin

Message:

JavaScriptCore:

Reviewed by Geoff, landed by Darin.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5307 Number.toFixed doesn't round 0.5 up

• kjs/number_object.cpp: (NumberProtoFunc::callAsFunction): Fixed a ">" that should have been a ">=".

LayoutTests:

Reviewed by Geoff, reworked and landed by Darin.

• test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5307 Number.toFixed doesn't round 0.5 up

• fast/js/number-tofixed-expected.txt: Added.
• fast/js/number-tofixed.html: Added.
• fast/js/resources/number-tofixed.js: Added.

File:

• trunk/JavaScriptCore/kjs/number_object.cpp (modified) (1 diff)

trunk/JavaScriptCore/kjs/number_object.cpp

@@ -213 +213 @@
       
       double n = floor(x*pow(10.0, f));
-      if (fabs(n / pow(10.0, f) - x) > fabs((n + 1) / pow(10.0, f) - x))
+      if (fabs(n / pow(10.0, f) - x) >= fabs((n + 1) / pow(10.0, f) - x))
           n++;