Ignore:
Timestamp:
Jun 13, 2012, 2:38:42 AM (13 years ago)
Author:
[email protected]
Message:

Unreviewed, rolling out r120172.
​http://trac.webkit.org/changeset/120172
​https://bugs.webkit.org/show_bug.cgi?id=88976

The patch causes compilation failures on Gtk, Qt and Apple Win
bots (Requested by zdobersek on #webkit).

Patch by Sheriff Bot <​[email protected]> on 2012-06-13

Source/JavaScriptCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::nop):
(JSC::ARMv7Assembler::label):
(JSC::ARMv7Assembler::readPointer):
(ARMv7Assembler):

  • assembler/AbstractMacroAssembler.h:

(JSC):
(AbstractMacroAssembler):
(Label):

  • assembler/AssemblerBuffer.h:
  • assembler/MacroAssemblerARM.h:
  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::nop):
(JSC::MacroAssemblerARMv7::jump):
(JSC::MacroAssemblerARMv7::makeBranch):

  • assembler/MacroAssemblerMIPS.h:
  • assembler/MacroAssemblerSH4.h:
  • assembler/MacroAssemblerX86.h:

(MacroAssemblerX86):
(JSC::MacroAssemblerX86::moveWithPatch):

  • assembler/MacroAssemblerX86Common.h:
  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::branchTest8):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::cmpb_im):
(JSC::X86Assembler::codeSize):
(JSC::X86Assembler::label):
(JSC::X86Assembler::X86InstructionFormatter::memoryModRM):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::appendOSRExit):
(JSC::CodeBlock::appendSpeculationRecovery):
(DFGData):

  • bytecode/DFGExitProfile.h:

(JSC::DFG::exitKindToString):
(JSC::DFG::exitKindIsCountable):

  • bytecode/Instruction.h:
  • bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

  • bytecode/Watchpoint.cpp: Removed.
  • bytecode/Watchpoint.h: Removed.
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::ResolveResult::checkValidity):
(JSC::BytecodeGenerator::addGlobalVar):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::resolve):
(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveWithBase):
(JSC::BytecodeGenerator::emitResolveWithThis):
(JSC::BytecodeGenerator::emitGetStaticVar):
(JSC::BytecodeGenerator::emitPutStaticVar):

  • bytecompiler/BytecodeGenerator.h:

(BytecodeGenerator):

  • bytecompiler/NodesCodegen.cpp:

(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::PostfixResolveNode::emitBytecode):
(JSC::PrefixResolveNode::emitBytecode):
(JSC::ReadModifyResolveNode::emitBytecode):
(JSC::AssignResolveNode::emitBytecode):
(JSC::ConstDeclNode::emitCodeSingle):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::clobberStructures):

  • dfg/DFGAbstractState.h:

(AbstractState):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCCallHelpers.h:

(JSC::DFG::CCallHelpers::setupArguments):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::globalVarStoreElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::run):

  • dfg/DFGCorrectableJumpPoint.h:
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::link):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasRegisterPointer):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::OSRExit):

  • dfg/DFGOSRExit.h:

(OSRExit):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):
(JSC::DFG::SpeculativeJIT::appendCallSetResult):
(JSC::DFG::SpeculativeJIT::speculationCheck):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:
  • jit/JITPropertyAccess.cpp:
  • jit/JITPropertyAccess32_64.cpp:
  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
  • llint/LLIntSlowPaths.cpp:
  • llint/LLIntSlowPaths.h:

(LLInt):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/JSObject.cpp:

(JSC::JSObject::removeDirect):

  • runtime/JSObject.h:

(JSObject):

  • runtime/JSSymbolTableObject.h:

(JSC::symbolTableGet):
(JSC::symbolTablePut):
(JSC::symbolTablePutWithAttributes):

  • runtime/SymbolTable.cpp: Removed.
  • runtime/SymbolTable.h:

(JSC):
(JSC::SymbolTableEntry::isNull):
(JSC::SymbolTableEntry::getIndex):
(SymbolTableEntry):
(JSC::SymbolTableEntry::getAttributes):
(JSC::SymbolTableEntry::isReadOnly):
(JSC::SymbolTableEntry::pack):
(JSC::SymbolTableEntry::isValidIndex):

Source/WTF:

  • wtf/SegmentedVector.h:

(WTF):
(SegmentedVectorIterator):
(WTF::SegmentedVectorIterator::operator=):
(WTF::SegmentedVectorIterator::SegmentedVectorIterator):
(SegmentedVector):

LayoutTests:

  • fast/js/dfg-call-function-hit-watchpoint-expected.txt: Removed.
  • fast/js/dfg-call-function-hit-watchpoint.html: Removed.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-call-function-hit-watchpoint.js: Removed.
File:
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/ChangeLog

    r120172 r120175  
     12012-06-13  Sheriff Bot  <[email protected]>
     2
     3        Unreviewed, rolling out r120172.
     4        http://trac.webkit.org/changeset/120172
     5        https://bugs.webkit.org/show_bug.cgi?id=88976
     6
     7        The patch causes compilation failures on Gtk, Qt and Apple Win
     8        bots (Requested by zdobersek on #webkit).
     9
     10        * CMakeLists.txt:
     11        * GNUmakefile.list.am:
     12        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
     13        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
     14        * JavaScriptCore.xcodeproj/project.pbxproj:
     15        * Target.pri:
     16        * assembler/ARMv7Assembler.h:
     17        (JSC::ARMv7Assembler::nop):
     18        (JSC::ARMv7Assembler::label):
     19        (JSC::ARMv7Assembler::readPointer):
     20        (ARMv7Assembler):
     21        * assembler/AbstractMacroAssembler.h:
     22        (JSC):
     23        (AbstractMacroAssembler):
     24        (Label):
     25        * assembler/AssemblerBuffer.h:
     26        * assembler/MacroAssemblerARM.h:
     27        * assembler/MacroAssemblerARMv7.h:
     28        (JSC::MacroAssemblerARMv7::nop):
     29        (JSC::MacroAssemblerARMv7::jump):
     30        (JSC::MacroAssemblerARMv7::makeBranch):
     31        * assembler/MacroAssemblerMIPS.h:
     32        * assembler/MacroAssemblerSH4.h:
     33        * assembler/MacroAssemblerX86.h:
     34        (MacroAssemblerX86):
     35        (JSC::MacroAssemblerX86::moveWithPatch):
     36        * assembler/MacroAssemblerX86Common.h:
     37        * assembler/MacroAssemblerX86_64.h:
     38        (JSC::MacroAssemblerX86_64::branchTest8):
     39        * assembler/X86Assembler.h:
     40        (JSC::X86Assembler::cmpb_im):
     41        (JSC::X86Assembler::codeSize):
     42        (JSC::X86Assembler::label):
     43        (JSC::X86Assembler::X86InstructionFormatter::memoryModRM):
     44        * bytecode/CodeBlock.cpp:
     45        (JSC::CodeBlock::dump):
     46        * bytecode/CodeBlock.h:
     47        (JSC::CodeBlock::appendOSRExit):
     48        (JSC::CodeBlock::appendSpeculationRecovery):
     49        (DFGData):
     50        * bytecode/DFGExitProfile.h:
     51        (JSC::DFG::exitKindToString):
     52        (JSC::DFG::exitKindIsCountable):
     53        * bytecode/Instruction.h:
     54        * bytecode/Opcode.h:
     55        (JSC):
     56        (JSC::padOpcodeName):
     57        * bytecode/Watchpoint.cpp: Removed.
     58        * bytecode/Watchpoint.h: Removed.
     59        * bytecompiler/BytecodeGenerator.cpp:
     60        (JSC::ResolveResult::checkValidity):
     61        (JSC::BytecodeGenerator::addGlobalVar):
     62        (JSC::BytecodeGenerator::BytecodeGenerator):
     63        (JSC::BytecodeGenerator::resolve):
     64        (JSC::BytecodeGenerator::emitResolve):
     65        (JSC::BytecodeGenerator::emitResolveWithBase):
     66        (JSC::BytecodeGenerator::emitResolveWithThis):
     67        (JSC::BytecodeGenerator::emitGetStaticVar):
     68        (JSC::BytecodeGenerator::emitPutStaticVar):
     69        * bytecompiler/BytecodeGenerator.h:
     70        (BytecodeGenerator):
     71        * bytecompiler/NodesCodegen.cpp:
     72        (JSC::FunctionCallResolveNode::emitBytecode):
     73        (JSC::PostfixResolveNode::emitBytecode):
     74        (JSC::PrefixResolveNode::emitBytecode):
     75        (JSC::ReadModifyResolveNode::emitBytecode):
     76        (JSC::AssignResolveNode::emitBytecode):
     77        (JSC::ConstDeclNode::emitCodeSingle):
     78        * dfg/DFGAbstractState.cpp:
     79        (JSC::DFG::AbstractState::execute):
     80        (JSC::DFG::AbstractState::clobberStructures):
     81        * dfg/DFGAbstractState.h:
     82        (AbstractState):
     83        * dfg/DFGByteCodeParser.cpp:
     84        (JSC::DFG::ByteCodeParser::handleInlining):
     85        (JSC::DFG::ByteCodeParser::parseBlock):
     86        * dfg/DFGCCallHelpers.h:
     87        (JSC::DFG::CCallHelpers::setupArguments):
     88        * dfg/DFGCSEPhase.cpp:
     89        (JSC::DFG::CSEPhase::globalVarStoreElimination):
     90        (JSC::DFG::CSEPhase::performNodeCSE):
     91        * dfg/DFGCapabilities.h:
     92        (JSC::DFG::canCompileOpcode):
     93        * dfg/DFGConstantFoldingPhase.cpp:
     94        (JSC::DFG::ConstantFoldingPhase::run):
     95        * dfg/DFGCorrectableJumpPoint.h:
     96        * dfg/DFGJITCompiler.cpp:
     97        (JSC::DFG::JITCompiler::linkOSRExits):
     98        (JSC::DFG::JITCompiler::link):
     99        * dfg/DFGNode.h:
     100        (JSC::DFG::Node::hasRegisterPointer):
     101        * dfg/DFGNodeType.h:
     102        (DFG):
     103        * dfg/DFGOSRExit.cpp:
     104        (JSC::DFG::OSRExit::OSRExit):
     105        * dfg/DFGOSRExit.h:
     106        (OSRExit):
     107        * dfg/DFGOperations.cpp:
     108        * dfg/DFGOperations.h:
     109        * dfg/DFGPredictionPropagationPhase.cpp:
     110        (JSC::DFG::PredictionPropagationPhase::propagate):
     111        * dfg/DFGSpeculativeJIT.h:
     112        (JSC::DFG::SpeculativeJIT::callOperation):
     113        (JSC::DFG::SpeculativeJIT::appendCallSetResult):
     114        (JSC::DFG::SpeculativeJIT::speculationCheck):
     115        * dfg/DFGSpeculativeJIT32_64.cpp:
     116        (JSC::DFG::SpeculativeJIT::compile):
     117        * dfg/DFGSpeculativeJIT64.cpp:
     118        (JSC::DFG::SpeculativeJIT::compile):
     119        * jit/JIT.cpp:
     120        (JSC::JIT::privateCompileMainPass):
     121        (JSC::JIT::privateCompileSlowCases):
     122        * jit/JIT.h:
     123        * jit/JITPropertyAccess.cpp:
     124        * jit/JITPropertyAccess32_64.cpp:
     125        * jit/JITStubs.cpp:
     126        * jit/JITStubs.h:
     127        * llint/LLIntSlowPaths.cpp:
     128        * llint/LLIntSlowPaths.h:
     129        (LLInt):
     130        * llint/LowLevelInterpreter32_64.asm:
     131        * llint/LowLevelInterpreter64.asm:
     132        * runtime/JSObject.cpp:
     133        (JSC::JSObject::removeDirect):
     134        * runtime/JSObject.h:
     135        (JSObject):
     136        * runtime/JSSymbolTableObject.h:
     137        (JSC::symbolTableGet):
     138        (JSC::symbolTablePut):
     139        (JSC::symbolTablePutWithAttributes):
     140        * runtime/SymbolTable.cpp: Removed.
     141        * runtime/SymbolTable.h:
     142        (JSC):
     143        (JSC::SymbolTableEntry::isNull):
     144        (JSC::SymbolTableEntry::getIndex):
     145        (SymbolTableEntry):
     146        (JSC::SymbolTableEntry::getAttributes):
     147        (JSC::SymbolTableEntry::isReadOnly):
     148        (JSC::SymbolTableEntry::pack):
     149        (JSC::SymbolTableEntry::isValidIndex):
     150
    11512012-06-12  Filip Pizlo  <[email protected]>
    2152
Note: See TracChangeset for help on using the changeset viewer.