Changeset 12028 in webkit for trunk/JavaScriptCore/kjs/math_object.cpp

Timestamp:

Jan 12, 2006, 8:58:46 AM (19 years ago)

Author:

darin

Message:

Reviewed by Geoff.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6505 retire APPLE_CHANGES from JavaScriptCore

• JavaScriptCore.xcodeproj/project.pbxproj: Removed both APPLE_CHANGES and HAVE_CONFIG_H from all targets.

• README: Removed. This had obsolete information in it and it wasn't clear what to replace it with.

• kjs/collector.h: Removed an APPLE_CHANGES if around something that's not really platform-specific (although it does use a platform-specific API at the moment).
• kjs/collector.cpp: Removed a mistaken comment.

• kjs/grammar.y:
• kjs/internal.cpp:
• kjs/object.h:
• kjs/operations.cpp:
• kjs/operations.h:
• kjs/ustring.h: Use APPLE instead of APPLE_CHANGES for code that should be used only on Mac OS X.

• kjs/interpreter.cpp: Removed APPLE_CHANGES ifdef around the include of the runtime.h header. Even though that header isn't needed at the moment on platforms other than Mac OS X, the conditional stuff should be in the header itself, not in this one client.

• kjs/math_object.cpp: (MathFuncImp::callAsFunction): Removed some code inside APPLE_CHANGES. I'm pretty sure this code isn't needed on any platform where pow is implemented corrrectly according to the IEEE standard. If it is needed on some, we can add it back with an appropriate #if for the platforms where it is needed.

File:

• trunk/JavaScriptCore/kjs/math_object.cpp (modified) (1 diff)

trunk/JavaScriptCore/kjs/math_object.cpp

@@ -238 +238 @@
     if (isNaN(arg2))
       result = NaN;
-#if !APPLE_CHANGES
-    else if (arg2 == 0)
-      result = 1;
-#endif
     else if (isNaN(arg) && arg2 != 0)
       result = NaN;
-#if !APPLE_CHANGES
-    else if (::fabs(arg) > 1 && KJS::isPosInf(arg2))
-      result = Inf;
-    else if (::fabs(arg) > 1 && KJS::isNegInf(arg2))
-      result = +0;
-#endif
     else if (::fabs(arg) == 1 && KJS::isInf(arg2))
       result = NaN;
-#if !APPLE_CHANGES
-    else if (::fabs(arg) < 1 && KJS::isPosInf(arg2))
-      result = +0;
-    else if (::fabs(arg) < 1 && KJS::isNegInf(arg2))
-      result = Inf;
-#endif
     else
       result = ::pow(arg, arg2);