Changeset 120786 in webkit for trunk/Source/JavaScriptCore/jit/JITPropertyAccess.cpp

Timestamp:

Jun 19, 2012, 6:33:30 PM (13 years ago)

Author:

[email protected]

Message:

JSC should be able to show disassembly for all generated JIT code
​https://bugs.webkit.org/show_bug.cgi?id=89536

Reviewed by Gavin Barraclough.

Now instead of doing linkBuffer.finalizeCode(), you do
FINALIZE_CODE(linkBuffer, (... explanation ...)). FINALIZE_CODE() then
prints your explanation and the disassembled code, if
Options::showDisassembly is set to true.

• CMakeLists.txt:
• GNUmakefile.list.am:
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
• JavaScriptCore.xcodeproj/project.pbxproj:
• Target.pri:
• assembler/LinkBuffer.cpp: Added.

(JSC):
(JSC::LinkBuffer::finalizeCodeWithoutDisassembly):
(JSC::LinkBuffer::finalizeCodeWithDisassembly):
(JSC::LinkBuffer::linkCode):
(JSC::LinkBuffer::performFinalization):
(JSC::LinkBuffer::dumpLinkStatistics):
(JSC::LinkBuffer::dumpCode):

• assembler/LinkBuffer.h:

(LinkBuffer):
(JSC):

• assembler/MacroAssemblerCodeRef.h:

(JSC::MacroAssemblerCodeRef::tryToDisassemble):
(MacroAssemblerCodeRef):

• dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):

• dfg/DFGOSRExitCompiler.cpp:
• dfg/DFGRepatch.cpp:

(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::emitPutReplaceStub):
(JSC::DFG::emitPutTransitionStub):

• dfg/DFGThunks.cpp:

(JSC::DFG::osrExitGenerationThunkGenerator):

• disassembler/Disassembler.h:

(JSC):
(JSC::tryToDisassemble):

• disassembler/UDis86Disassembler.cpp:

(JSC::tryToDisassemble):

• jit/JIT.cpp:

(JSC::JIT::privateCompile):

• jit/JITCode.h:

(JSC::JITCode::tryToDisassemble):

• jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):

• jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):

• jit/JITPropertyAccess.cpp:

(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):

• jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):

• jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::finalize):

• jit/ThunkGenerators.cpp:

(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::floorThunkGenerator):
(JSC::ceilThunkGenerator):
(JSC::roundThunkGenerator):
(JSC::expThunkGenerator):
(JSC::logThunkGenerator):
(JSC::absThunkGenerator):
(JSC::powThunkGenerator):

• llint/LLIntThunks.cpp:

(JSC::LLInt::generateThunkWithJumpTo):
(JSC::LLInt::functionForCallEntryThunkGenerator):
(JSC::LLInt::functionForConstructEntryThunkGenerator):
(JSC::LLInt::functionForCallArityCheckThunkGenerator):
(JSC::LLInt::functionForConstructArityCheckThunkGenerator):
(JSC::LLInt::evalEntryThunkGenerator):
(JSC::LLInt::programEntryThunkGenerator):

• runtime/Options.cpp:

(Options):
(JSC::Options::initializeOptions):

• runtime/Options.h:

(Options):

• yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::compile):

File:

• trunk/Source/JavaScriptCore/jit/JITPropertyAccess.cpp (modified) (8 diffs)

trunk/Source/JavaScriptCore/jit/JITPropertyAccess.cpp

@@ -89 +89 @@
     
     LinkBuffer patchBuffer(*globalData, &jit, GLOBAL_THUNK_ID);
-    return patchBuffer.finalizeCode();
+    return FINALIZE_CODE(patchBuffer, ("String get_by_val stub"));
 }
 
@@ -565 +565 @@
     }
     
-    stubInfo->stubRoutine = patchBuffer.finalizeCode();
+    stubInfo->stubRoutine = FINALIZE_CODE(
+        patchBuffer,
+        ("Baseline put_by_id transition for CodeBlock %p, return point %p",
+         m_codeBlock, returnAddress.value()));
     RepatchBuffer repatchBuffer(m_codeBlock);
     repatchBuffer.relinkCallerToTrampoline(returnAddress, CodeLocationLabel(stubInfo->stubRoutine.code()));
@@ -626 +629 @@
 
     // Track the stub we have created so that it will be deleted later.
-    stubInfo->stubRoutine = patchBuffer.finalizeCode();
+    stubInfo->stubRoutine = FINALIZE_CODE(
+        patchBuffer,
+        ("Basline JIT get_by_id array length stub for CodeBlock %p, return point %p",
+         m_codeBlock, stubInfo->hotPathBegin.labelAtOffset(
+             stubInfo->patch.baseline.u.get.putResult).executableAddress()));
 
     // Finally patch the jump to slow case back in the hot path to jump here instead.
@@ -689 +696 @@
     }
     // Track the stub we have created so that it will be deleted later.
-    stubInfo->stubRoutine = patchBuffer.finalizeCode();
+    stubInfo->stubRoutine = FINALIZE_CODE(
+        patchBuffer,
+        ("Baseline JIT get_by_id proto stub for CodeBlock %p, return point %p",
+         m_codeBlock, stubInfo->hotPathBegin.labelAtOffset(
+             stubInfo->patch.baseline.u.get.putResult).executableAddress()));
 
     // Finally patch the jump to slow case back in the hot path to jump here instead.
@@ -746 +757 @@
     patchBuffer.link(success, stubInfo->hotPathBegin.labelAtOffset(stubInfo->patch.baseline.u.get.putResult));
 
-    MacroAssemblerCodeRef stubCode = patchBuffer.finalizeCode();
+    MacroAssemblerCodeRef stubCode = FINALIZE_CODE(
+        patchBuffer,
+        ("Baseline JIT get_by_id list stub for CodeBlock %p, return point %p",
+         m_codeBlock, stubInfo->hotPathBegin.labelAtOffset(
+             stubInfo->patch.baseline.u.get.putResult).executableAddress()));
 
     polymorphicStructures->list[currentIndex].set(*m_globalData, m_codeBlock->ownerExecutable(), stubCode, structure, isDirect);
@@ -812 +827 @@
     patchBuffer.link(success, stubInfo->hotPathBegin.labelAtOffset(stubInfo->patch.baseline.u.get.putResult));
 
-    MacroAssemblerCodeRef stubCode = patchBuffer.finalizeCode();
+    MacroAssemblerCodeRef stubCode = FINALIZE_CODE(
+        patchBuffer,
+        ("Baseline JIT get_by_id proto list stub for CodeBlock %p, return point %p",
+         m_codeBlock, stubInfo->hotPathBegin.labelAtOffset(
+             stubInfo->patch.baseline.u.get.putResult).executableAddress()));
     prototypeStructures->list[currentIndex].set(*m_globalData, m_codeBlock->ownerExecutable(), stubCode, structure, prototypeStructure, isDirect);
 
@@ -881 +900 @@
     patchBuffer.link(success, stubInfo->hotPathBegin.labelAtOffset(stubInfo->patch.baseline.u.get.putResult));
 
-    CodeRef stubRoutine = patchBuffer.finalizeCode();
+    CodeRef stubRoutine = FINALIZE_CODE(
+        patchBuffer,
+        ("Baseline JIT get_by_id chain list stub for CodeBlock %p, return point %p",
+         m_codeBlock, stubInfo->hotPathBegin.labelAtOffset(
+             stubInfo->patch.baseline.u.get.putResult).executableAddress()));
 
     // Track the stub we have created so that it will be deleted later.
@@ -948 +971 @@
 
     // Track the stub we have created so that it will be deleted later.
-    CodeRef stubRoutine = patchBuffer.finalizeCode();
+    CodeRef stubRoutine = FINALIZE_CODE(
+        patchBuffer,
+        ("Baseline JIT get_by_id chain stub for CodeBlock %p, return point %p",
+         m_codeBlock, stubInfo->hotPathBegin.labelAtOffset(
+             stubInfo->patch.baseline.u.get.putResult).executableAddress()));
     stubInfo->stubRoutine = stubRoutine;