Changeset 121607 in webkit for trunk/Source/JavaScriptCore/heap/Heap.cpp

Timestamp:

Jun 29, 2012, 6:14:09 PM (13 years ago)

Author:

[email protected]

Message:

Remove warning about protected values when the Heap is being destroyed
​https://bugs.webkit.org/show_bug.cgi?id=90302

Reviewed by Geoffrey Garen.

Having to do book-keeping about whether values allocated from a certain
VM are or are not protected makes the JSC API much more difficult to use
correctly. Clients should be able to throw an entire VM away and not have
to worry about unprotecting all of the values that they protected earlier.

• heap/Heap.cpp:

(JSC::Heap::lastChanceToFinalize):

File:

• trunk/Source/JavaScriptCore/heap/Heap.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/heap/Heap.cpp

@@ -270 +270 @@
     ASSERT(m_operationInProgress == NoOperation);
 
-    // FIXME: Make this a release-mode crash once we're sure no one's doing this.
-    if (size_t size = m_protectedValues.size())
-        WTFLogAlways("ERROR: JavaScriptCore heap deallocated while %ld values were still protected", static_cast<unsigned long>(size));
-
     m_objectSpace.lastChanceToFinalize();