Changeset 122341 in webkit for trunk/Source/JavaScriptCore/jsc.cpp

Timestamp:

Jul 11, 2012, 10:50:15 AM (13 years ago)

Author:

[email protected]

Message:

jsc: Parse options before creating global data
​https://bugs.webkit.org/show_bug.cgi?id=90975

Reviewed by Filip Pizlo.

This patch moves the options parsing in "jsc" before the creation
of the JSGlobalData, so that --useJIT=no has a chance to take
effect.

• jsc.cpp:

(CommandLine::parseArguments): Refactor to be a class, and take
argc and argv as constructor arguments.
(jscmain): Move arg parsing before JSGlobalData creation.

File:

• trunk/Source/JavaScriptCore/jsc.cpp (modified) (7 diffs)

trunk/Source/JavaScriptCore/jsc.cpp

@@ -114 +114 @@
 };
 
-struct CommandLine {
-    CommandLine()
-        : interactive(false)
-        , dump(false)
-        , exitCode(false)
+class CommandLine {
+public:
+    CommandLine(int argc, char** argv)
+        : m_interactive(false)
+        , m_dump(false)
+        , m_exitCode(false)
     {
-    }
-
-    bool interactive;
-    bool dump;
-    bool exitCode;
-    Vector<Script> scripts;
-    Vector<UString> arguments;
+        parseArguments(argc, argv);
+    }
+
+    bool m_interactive;
+    bool m_dump;
+    bool m_exitCode;
+    Vector<Script> m_scripts;
+    Vector<UString> m_arguments;
+
+    void parseArguments(int, char**);
 };
 
@@ -624 +628 @@
 }
 
-static void parseArguments(int argc, char** argv, CommandLine& options)
+void CommandLine::parseArguments(int argc, char** argv)
 {
     int i = 1;
@@ -635 +639 @@
             if (++i == argc)
                 printUsageStatement();
-            options.scripts.append(Script(true, argv[i]));
+            m_scripts.append(Script(true, argv[i]));
             continue;
         }
@@ -641 +645 @@
             if (++i == argc)
                 printUsageStatement();
-            options.scripts.append(Script(false, argv[i]));
+            m_scripts.append(Script(false, argv[i]));
             continue;
         }
         if (!strcmp(arg, "-i")) {
-            options.interactive = true;
+            m_interactive = true;
             continue;
         }
         if (!strcmp(arg, "-d")) {
-            options.dump = true;
+            m_dump = true;
             continue;
         }
@@ -662 +666 @@
         }
         if (!strcmp(arg, "-x")) {
-            options.exitCode = true;
+            m_exitCode = true;
             continue;
         }
@@ -691 +695 @@
         // This arg is not recognized by the VM nor by jsc. Pass it on to the
         // script.
-        options.scripts.append(Script(true, argv[i]));
-    }
-
-    if (options.scripts.isEmpty())
-        options.interactive = true;
+        m_scripts.append(Script(true, argv[i]));
+    }
+
+    if (m_scripts.isEmpty())
+        m_interactive = true;
 
     for (; i < argc; ++i)
-        options.arguments.append(argv[i]);
+        m_arguments.append(argv[i]);
 
     if (needToDumpOptions)
@@ -708 +712 @@
 int jscmain(int argc, char** argv)
 {
+    // Note that the options parsing can affect JSGlobalData creation, and thus
+    // comes first.
+    CommandLine options(argc, argv);
     RefPtr<JSGlobalData> globalData = JSGlobalData::create(ThreadStackTypeLarge, LargeHeap);
     JSLockHolder lock(globalData.get());
     int result;
 
-    CommandLine options;
-    parseArguments(argc, argv, options);
-
-    GlobalObject* globalObject = GlobalObject::create(*globalData, GlobalObject::createStructure(*globalData, jsNull()), options.arguments);
-    bool success = runWithScripts(globalObject, options.scripts, options.dump);
-    if (options.interactive && success)
+    GlobalObject* globalObject = GlobalObject::create(*globalData, GlobalObject::createStructure(*globalData, jsNull()), options.m_arguments);
+    bool success = runWithScripts(globalObject, options.m_scripts, options.m_dump);
+    if (options.m_interactive && success)
         runInteractive(globalObject);
 
     result = success ? 0 : 3;
 
-    if (options.exitCode)
+    if (options.m_exitCode)
         printf("jsc exiting %d\n", result);