Changeset 12328 in webkit for trunk/JavaScriptCore/kxmlcore/HashSet.h

Timestamp:

Jan 23, 2006, 10:24:11 PM (19 years ago)

Author:

mjs

Message:

Reviewed by Tim Omernick.

• use classes instead of free functions for extractors, this better matches how other things work and should avoid the need for hacky workarounds on other compilers ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6748

• kjs/array_object.cpp:
• kjs/identifier.cpp:
• kjs/internal.cpp:
• kxmlcore/HashMap.h: (KXMLCore::PairFirstExtractor::extract):
• kxmlcore/HashMapPtrSpec.h: (KXMLCore::):
• kxmlcore/HashSet.h: (KXMLCore::IdentityExtractor::extract):
• kxmlcore/HashTable.h: (KXMLCore::addIterator): (KXMLCore::removeIterator): (KXMLCore::HashTable::add): (KXMLCore::HashTable::isEmptyBucket): (KXMLCore::HashTable::isDeletedBucket): (KXMLCore::HashTable::HashTable): (KXMLCore::HashTable::lookup): (KXMLCore::HashTable::add): (KXMLCore::HashTable::reinsert): (KXMLCore::HashTable::find): (KXMLCore::HashTable::contains): (KXMLCore::HashTable::remove): (KXMLCore::HashTable::allocateTable): (KXMLCore::HashTable::deallocateTable): (KXMLCore::HashTable::expand): (KXMLCore::HashTable::rehash): (KXMLCore::HashTable::clear): (KXMLCore::HashTable::swap): (KXMLCore::HashTable::operator): (KXMLCore::HashTable::checkTableConsistency): (KXMLCore::HashTable::checkTableConsistencyExceptSize): (KXMLCore::HashTable::invalidateIterators):

File:

• trunk/JavaScriptCore/kxmlcore/HashSet.h (modified) (2 diffs)

trunk/JavaScriptCore/kxmlcore/HashSet.h

@@ -31 +31 @@
 
     template <typename T>
-    inline const T& identityExtract(const T& t) 
-    { 
-        return t; 
-    }
-
+    struct IdentityExtractor
+    {
+        static const T& extract(const T& t) 
+        { 
+            return t; 
+        }
+    };
 
     template<typename Value, typename T, typename HashSetTranslator>
@@ -59 +61 @@
     class HashSet {
     private:
-        typedef HashTable<Value, Value, identityExtract<Value>, HashFunctions, Traits, Traits> ImplType;
+        typedef HashTable<Value, Value, IdentityExtractor<Value>, HashFunctions, Traits, Traits> ImplType;
     public:
         typedef Value ValueType;