Changeset 123690 in webkit for trunk/Source/JavaScriptCore/heap/MarkStack.h

Timestamp:

Jul 25, 2012, 6:22:59 PM (13 years ago)

Author:

[email protected]

Message:

JSC GC object copying APIs should allow for greater flexibility
​https://bugs.webkit.org/show_bug.cgi?id=92316

Reviewed by Mark Hahnenberg.

It's now the case that visitChildren() methods can directly pin and allocate in new space during copying.
They can also do the copying and marking themselves. This new API is only used for JSObjects for now.

• JavaScriptCore.xcodeproj/project.pbxproj:
• heap/MarkStack.cpp:

(JSC::SlotVisitor::allocateNewSpaceSlow):
(JSC::SlotVisitor::allocateNewSpaceOrPin):
(JSC):
(JSC::SlotVisitor::copyAndAppend):

• heap/MarkStack.h:

(MarkStack):
(JSC::MarkStack::appendUnbarrieredValue):
(JSC):

• heap/SlotVisitor.h:
• heap/SlotVisitorInlineMethods.h: Added.

(JSC):
(JSC::SlotVisitor::checkIfShouldCopyAndPinOtherwise):
(JSC::SlotVisitor::allocateNewSpace):

• runtime/JSObject.cpp:

(JSC::JSObject::visitOutOfLineStorage):
(JSC):
(JSC::JSObject::visitChildren):
(JSC::JSFinalObject::visitChildren):

• runtime/JSObject.h:

(JSObject):

File:

• trunk/Source/JavaScriptCore/heap/MarkStack.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/heap/MarkStack.h

@@ -254 +254 @@
         template<typename T>
         void appendUnbarrieredPointer(T**);
+        void appendUnbarrieredValue(JSValue*);
         
         void addOpaqueRoot(void*);
@@ -454 +455 @@
     }
 
+    ALWAYS_INLINE void MarkStack::appendUnbarrieredValue(JSValue* slot)
+    {
+        ASSERT(slot);
+        internalAppend(*slot);
+    }
+
     ALWAYS_INLINE void MarkStack::append(JSCell** slot)
     {