Changeset 12435 in webkit for trunk/JavaScriptCore/kjs/number_object.cpp

Timestamp:

Jan 28, 2006, 8:12:59 PM (19 years ago)

Author:

mjs

Message:

Reviewed by Dave Hyatt.

• added a Vector class ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6894

• JavaScriptCore.xcodeproj/project.pbxproj:
• kjs/internal.cpp: (KJS::Parser::saveNewNode): Apply Vector. (KJS::clearNewNodes): ditto
• kjs/number_object.cpp: (integer_part_noexp): ditto (char_sequence): ditto
• kjs/ustring.cpp: (KJS::UString::UTF8String): ditto
• kxmlcore/HashMap.h: (KXMLCore::deleteAllValues): Tweaked this to only apply to HashMap, other versions are useful for other containers.
• kxmlcore/Vector.h: Added. Implemented a Vector class, which should be usable for all Array/QVector style purposes, and also as a stack buffer with oversize handling. Also some helper classes to make vector operations as efficient as possible for POD types and for simple non-PODs like RefPtr. (KXMLCore::): (KXMLCore::VectorTypeOperations::destruct): (KXMLCore::VectorTypeOperations::initialize): (KXMLCore::VectorTypeOperations::move): (KXMLCore::VectorTypeOperations::uninitializedCopy): (KXMLCore::VectorTypeOperations::uninitializedFill): (KXMLCore::VectorBuffer::VectorBuffer): (KXMLCore::VectorBuffer::~VectorBuffer): (KXMLCore::VectorBuffer::deallocateBuffer): (KXMLCore::VectorBuffer::inlineBuffer): (KXMLCore::Vector::Vector): (KXMLCore::Vector::~Vector): (KXMLCore::Vector::size): (KXMLCore::Vector::capacity): (KXMLCore::Vector::isEmpty): (KXMLCore::Vector::at): (KXMLCore::Vector::operator[]): (KXMLCore::Vector::data): (KXMLCore::Vector::operator T*): (KXMLCore::Vector::operator const T*): (KXMLCore::Vector::begin): (KXMLCore::Vector::end): (KXMLCore::Vector::clear): (KXMLCore::Vector::fill): (KXMLCore::Vector::operator=): (KXMLCore::::Vector): (KXMLCore::::operator): (KXMLCore::::fill): (KXMLCore::::expandCapacity): (KXMLCore::::resize): (KXMLCore::::reserveCapacity): (KXMLCore::::append): (KXMLCore::deleteAllValues):
• kxmlcore/VectorTraits.h: Added. (KXMLCore::VectorTraits): Traits to enable making Vector efficient for simple types.

File:

• trunk/JavaScriptCore/kjs/number_object.cpp (modified) (3 diffs)

trunk/JavaScriptCore/kjs/number_object.cpp

@@ -30 +30 @@
 #include "dtoa.h"
 
+#include <kxmlcore/Vector.h>
+
 #include "number_object.lut.h"
 
 #include <assert.h>
 #include <math.h>
+
 using namespace KJS;
 
@@ -95 +98 @@
         str += UString("0");
     } else {
-        char *buf;
+        Vector<char, 1024> buf(decimalPoint + 1);
         
         if (length <= decimalPoint) {
-            buf = (char*)fastMalloc(decimalPoint+1);
-            strcpy(buf,result);
-            memset(buf+length,'0',decimalPoint-length);
-        } else {
-            buf = (char*)fastMalloc(decimalPoint+1);
-            strncpy(buf,result,decimalPoint);
-        }
+            strcpy(buf, result);
+            memset(buf + length, '0', decimalPoint - length);
+        } else
+            strncpy(buf, result, decimalPoint);
         
         buf[decimalPoint] = '\0';
         str += UString(buf);
-        fastFree(buf);
     }
     
@@ -118 +117 @@
 static UString char_sequence(char c, int count)
 {
-    char *buf = (char*)fastMalloc(count+1);
-    memset(buf,c,count);
+    Vector<char, 2048> buf(count + 1, c);
     buf[count] = '\0';
-    UString s(buf);
-    fastFree(buf);
-    return s;
+
+    return UString(buf);
 }