Changeset 12564 in webkit for trunk/JavaScriptCore/kjs/object.cpp

Timestamp:

Feb 4, 2006, 5:43:16 PM (19 years ago)

Author:

darin

Message:

Reviewed by Maciej.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5210 REGRESSION: for/in loop with var changes global variable instead of making local

Test: fast/js/for-in-var-scope.html

• kjs/nodes.cpp: (valueForReadModifyAssignment): Use ALWAYS_INLINE macro. (ForInNode::execute): Break out of the scope chain loop once we find and set the loop variable. We don't want to set multiple loop variables. (ForInNode::processVarDecls): Process the declaration of the loop variable.

• other cleanup

• kjs/object.cpp: (KJS::tryGetAndCallProperty): Use ALWAYS_INLINE macro.
• kxmlcore/FastMalloc.cpp: Change to use ALWAYS_INLINE macro from AlwaysInline.h instead of defining it here a second time.

File:

• trunk/JavaScriptCore/kjs/object.cpp (modified) (1 diff)

trunk/JavaScriptCore/kjs/object.cpp

@@ -328 +328 @@
 }
 
-static inline
-#ifdef __GNUC__
-__attribute__((always_inline))
-#endif
-JSValue *tryGetAndCallProperty(ExecState *exec, const JSObject *object, const Identifier &propertyName) {
+static ALWAYS_INLINE JSValue *tryGetAndCallProperty(ExecState *exec, const JSObject *object, const Identifier &propertyName) {
   JSValue *v = object->get(exec, propertyName);
   if (v->isObject()) {