Changeset 12564 in webkit for trunk/JavaScriptCore/kxmlcore/FastMalloc.cpp

Timestamp:

Feb 4, 2006, 5:43:16 PM (19 years ago)

Author:

darin

Message:

Reviewed by Maciej.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5210 REGRESSION: for/in loop with var changes global variable instead of making local

Test: fast/js/for-in-var-scope.html

• kjs/nodes.cpp: (valueForReadModifyAssignment): Use ALWAYS_INLINE macro. (ForInNode::execute): Break out of the scope chain loop once we find and set the loop variable. We don't want to set multiple loop variables. (ForInNode::processVarDecls): Process the declaration of the loop variable.

• other cleanup

• kjs/object.cpp: (KJS::tryGetAndCallProperty): Use ALWAYS_INLINE macro.
• kxmlcore/FastMalloc.cpp: Change to use ALWAYS_INLINE macro from AlwaysInline.h instead of defining it here a second time.

File:

• trunk/JavaScriptCore/kxmlcore/FastMalloc.cpp (modified) (2 diffs)

trunk/JavaScriptCore/kxmlcore/FastMalloc.cpp

@@ -96 +96 @@
 }
 
-#ifndef WIN32
+#if !WIN32
 void fastMallocRegisterThread(pthread_t thread) 
 {
@@ -106 +106 @@
 #else
 
-#include <new>
-#include <stdio.h>
-#include <stddef.h>
-#if defined HAVE_STDINT_H
+#if HAVE_STDINT_H
 #include <stdint.h>
-#elif defined HAVE_INTTYPES_H
+#elif HAVE_INTTYPES_H
 #include <inttypes.h>
 #else
 #include <sys/types.h>
 #endif
+
+#include "AlwaysInline.h"
+#include "Assertions.h"
+#include "TCPageMap.h"
+#include "TCSpinLock.h"
+#include "TCSystemAlloc.h"
+#include <errno.h>
+#include <new>
+#include <pthread.h>
+#include <stdarg.h>
+#include <stddef.h>
+#include <stdio.h>
 #include <string.h>
-#include <pthread.h>
 #include <unistd.h>
-#include <errno.h>
-#include <stdarg.h>
-#include "TCSpinLock.h"
-#include "TCPageMap.h"
-#include "TCSystemAlloc.h"
-
-#include "Assertions.h"
-
-#ifdef __GNUC__
-#define ALWAYS_INLINE inline __attribute__((always_inline))
-#else
-#define ALWAYS_INLINE inline
-#endif
 
 #if KXC_CHANGES