Changeset 125823 in webkit for trunk/Source/JavaScriptCore/dfg/DFGDriver.cpp

Timestamp:

Aug 16, 2012, 4:17:24 PM (13 years ago)

Author:

[email protected]

Message:

Structure check hoisting should be less expensive
​https://bugs.webkit.org/show_bug.cgi?id=94201

Reviewed by Mark Hahnenberg.

This appears like a broad win on short-running programs.

• dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):

• dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::performNodeCSE):

• dfg/DFGDriver.cpp:

(JSC::DFG::compile):

• dfg/DFGGraph.h:

(JSC::DFG::Graph::compareAndSwap):
(Graph):
(JSC::DFG::Graph::substitute):
(JSC::DFG::Graph::substituteGetLocal):

• dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):

File:

• trunk/Source/JavaScriptCore/dfg/DFGDriver.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/dfg/DFGDriver.cpp

@@ -91 +91 @@
     performPredictionPropagation(dfg);
     performFixup(dfg);
+    performStructureCheckHoisting(dfg);
     unsigned cnt = 1;
     for (;; ++cnt) {
@@ -107 +108 @@
         performFixup(dfg);
     }
-    bool shouldRedoCFA = performStructureCheckHoisting(dfg);
     performCSE(dfg, FixpointConverged);
-    if (shouldRedoCFA)
-        performCFA(dfg);
 #if DFG_ENABLE(DEBUG_VERBOSE)
     dataLog("DFG optimization fixpoint converged in %u iterations.\n", cnt);