Changeset 12624 in webkit for trunk/JavaScriptCore/kjs/date_object.h

Timestamp:

Feb 6, 2006, 10:11:17 PM (19 years ago)

Author:

ap

Message:

Reviewed by Darin.

• Refactor DateInstance to provide direct access to data. Several WIN32 modifications. ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7107

• No tests added - only changed functionality on WIN32, which should be covered by existing tests.

• kjs/date_object.cpp: (gmtoffset): On WIN32, use the recommended global (_timezone rather than timezone). Updated comments. (KJS::timeZoneOffset): Removed, was basically the same as the above. (KJS::formatTime): Pass an UTC flag - UTC/local cannot be correctly selected on Windows based on struct tm itself. (KJS::DateInstance::getTime): Added. (KJS::DateInstance::getUTCTime): Added. (KJS::millisecondsToTM): Factored out from DateProtoFunc::callAsFunction(). (KJS::DateObjectImp::callAsFunction): Use the new parameter to formatTime(). (KJS::DateProtoFunc::callAsFunction): Updated for the other changes. The code for GetTimezoneOffset was incorrect on WIN32 - _daylight global has nothing to do with daylight savings time being in effect.

• kjs/date_object.h: Added prototypes for new functions.

File:

• trunk/JavaScriptCore/kjs/date_object.h (modified) (1 diff)

trunk/JavaScriptCore/kjs/date_object.h

@@ -32 +32 @@
     public:
         DateInstance(JSObject *proto);
-
+        
+        bool getTime(tm &t, int &gmtoffset) const;
+        bool getUTCTime(tm &t) const;
+        bool getTime(double &ms, int &gmtoffset) const;
+        bool getUTCTime(double &ms) const;
+        
         virtual const ClassInfo *classInfo() const { return &info; }
         static const ClassInfo info;